Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account id endpoint metric #3055

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yenfryherrerafeliz
Copy link
Contributor

Description of changes:

  • Captures the AccountIdEndpointMode metric just if the parameter is defined in the ruleset.
  • Captures the account id endpoint metric whenever an account id endpoint was resolved by the endpoint middleware.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Captures the AccountIdEndpointMode metric just if the parameter is defined in the ruleset.
- Captures the account id endpoint metric whenever an account id endpoint was resolved by the endpoint middleware.
src/MetricsBuilder.php Outdated Show resolved Hide resolved
src/MetricsBuilder.php Outdated Show resolved Hide resolved
src/EndpointV2/EndpointV2Middleware.php Outdated Show resolved Hide resolved
- Abstract the endpoint related metrics gathering into a single method in order to keep the code cleaner.
- Use self instead of class name for referencing to constants from the same context/class.
@yenfryherrerafeliz
Copy link
Contributor Author

Integ tests:

vendor/bin/behat --format=progress --tags=integ
...................................................................... 70
...................................................................... 140
...................................................................... 210
....................

60 scenarios (60 passed)
230 steps (230 passed)
8m43.19s (45.10Mb)

Smoke tests:

vendor/bin/behat --format=progress --suite=smoke --tags='~@noassumerole'
...................................................................... 70
...................................................................... 140
...................................................................... 210
..............

112 scenarios (112 passed)
224 steps (224 passed)
0m43.69s (94.04Mb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants