fix: EC2 empty list serialization #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenfryherrerafeliz
force-pushed
the
fix_ec2_empty_list_serialization
branch
from
094919d to
a6ac2e0
Compare
|
Were the smoke and integ tests ran against this change? |
stobrien89
requested changes
Jun 5, 2024
yenfryherrerafeliz
force-pushed
the
fix_ec2_empty_list_serialization
branch
2 times, most recently
from
036b8ac to
13ec5d0
Compare
Empty lists should not be serialized when doing EC2 requests, instead the parameter must be ignored. Otherwise, the service will return an InvalidRequest exception.
yenfryherrerafeliz
force-pushed
the
fix_ec2_empty_list_serialization
branch
from
13ec5d0 to
74213cc
Compare
stobrien89
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Empty list parameters should not be serialized when doing EC2 requests, instead the parameters must be ignored. Otherwise, the service will return an InvalidRequest exception
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.