-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support removing unused services only in dev environment #2581
feat: Support removing unused services only in dev environment #2581
Conversation
@stobrien89 Could you help me to review the PR? |
@stobrien89 Have you any time help me to review the PR? |
Hi @kayw-geek, Sorry for the delay. Haven't forgotten about this— We have a backlog of higher priority PRs we'll need to merge first, but we plan to focus more on community contributions in the coming weeks. I'll let you know when I have a chance to review! |
Sure, never mind, it is not a important PR, thank your help me. |
@
Hi @stobrien89 You got a minute? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kayw-geek,
Sorry again for the delay. This looks good for the most part, just had a nit and question about backward-compatibility. We're deprecating PHP < 7.2.5 in a few months, so we might want to wait until that happens to be sure there won't be any issues.
9a606fa
to
c2e5220
Compare
Hi @stobrien89, I hope you're having a great day. I wanted to follow up on my PR and see if you had any feedback or suggestions. If you need any additional information or have any questions, please don't hesitate to ask. Thank you for your time and effort. |
@stobrien89 Could you please review this again thanks |
c2e5220
to
2fc8304
Compare
Hi @yenfryherrerafeliz, I have updated these code, could you please review this again thanks. |
Thanks @kayw-geek! Apologies for the delay on this. |
Before people always to removing those unused services in any environments, If they miss some services that they are still using, that will cause some risks.
Now you can use the
onlyRemoveUnusedServicesInDev
method to avoid the risks.