enhancement: sqs response md5 validation (#2830)

aws · Nov 17, 2023 · fc43613 · fc43613
1 parent 5b8a381
commit fc43613
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 1 deletion.
diff --git a/.changes/nextrelease/sqs-response-middleware.json b/.changes/nextrelease/sqs-response-middleware.json
@@ -0,0 +1,7 @@
+[
+  {
+    "type": "enhancement",
+    "category": "Sqs",
+    "description": "Updates response md5 validation"
+  }
+]
diff --git a/src/Sqs/SqsClient.php b/src/Sqs/SqsClient.php
@@ -215,7 +215,7 @@ function ($result) use ($c, $r) {
                                             ]
                                         );
                                     }
-                                } else if (isset($msg['MessageAttributes'])) {
+                                } else if (!empty($msg['MessageAttributes'])) {
                                     throw new SqsException(
                                         sprintf(
                                             'No Attribute MD5 found. Expected %s',

diff --git a/tests/Sqs/SqsClientTest.php b/tests/Sqs/SqsClientTest.php
@@ -165,4 +165,31 @@ public function testSkipsCommandsThatAreNotReceiveMessage()
         $this->addMockResults($client, [new Result()]);
         $client->listQueues();
     }
+
+    public function testDoesNotValidateEmptyMessageAttributes()
+    {
+        $client = new SqsClient([
+            'region'  => 'us-west-2',
+            'version' => 'latest'
+        ]);
+
+        $mock = new Result([
+            'Messages' => [
+                [
+                    'Body' => 'Test',
+                    'MessageAttributes' => []
+                ]
+            ]
+        ]);
+
+        $this->addMockResults($client, [$mock]);
+        $response = $client->receiveMessage([
+            'QueueUrl' => 'http://foo.com',
+            'MessageAttributeNames' => [
+                'All'
+            ],
+        ]);
+
+        $this->assertEmpty($response->get('MessageAttributes'));
+    }
 }