chore(credential-providers): move base fromTempCreds impl to non-browser file #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromTemporaryCredentialshas a Node.js implementation which "extends" the base implementation. The browser implementation is identical to the base implementation.Because of that, I allowed the base impl to sit in the browser file, and the Node.js implementation imported the browser file.
However, in some build transforms outside of this repository, we may delete anything with the pattern
*.browser.{js|ts}when creating Node.js artifacts. This would make the Node.js implementation stop working because of the import.