Add SharedModelsValidator #6146
Open
+1,222
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validator ensures that when two services share models, any shared model definitions are identical.
dagnir
force-pushed
the
dongie/shared-models-validation-pt3
branch
from
c29b20c to
20cf7d5
Compare
|
L-Applin
reviewed
Jun 3, 2025
| import software.amazon.awssdk.codegen.validation.ValidationEntry; | ||
| import software.amazon.awssdk.utils.Logger; | ||
|
|
||
| public class CodeGenerator { | ||
| private static final Logger log = Logger.loggerFor(CodeGenerator.class); | ||
| private static final String MODEL_DIR_NAME = "models"; | ||
|
|
||
| // TODO: add validators | ||
| private static final List<ModelValidator> DEFAULT_MODEL_VALIDATORS = Collections.emptyList(); | ||
| private static final List<ModelValidator> DEFAULT_MODEL_VALIDATORS = Collections.singletonList( |
There was a problem hiding this comment.
Just to double check, if some validators are manually specified in the CodeGenerator.Builder it will override the DEFAULT_MODEL_VALIDATORS. Is that what we want?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This validator ensures that when two services share models, any shared model definitions are identical.
Modifications
The diff is on the larger side, but most of the added lines are from the IntelliJ-generated
equals()andhashCode()implementations.The important changes are in
SharedModelsValidator.javaandSharedModelsValidatorTest.java.Testing
AttributeValueindynamodband verifying that codegen fails with theSHARED_MODELS_DIFFERerror.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License