Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set response code after receiving header #3241

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Set response code after receiving header #3241

merged 5 commits into from
Jan 14, 2025

Conversation

sbera87
Copy link
Contributor

@sbera87 sbera87 commented Jan 10, 2025

Issue #, if available:
#3234
Description of changes:
Set response code after receiving all headers
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -2580,4 +2580,39 @@ namespace
AWS_EXPECT_SUCCESS(headOutcome);
EXPECT_EQ(headOutcome.GetResult().GetContentEncoding(), "gzip");
}

TEST_F(BucketAndObjectOperationTest, TestHeaderResponse) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: un-indent to match indentation of file

{
long responseCode{-1};
curl_easy_getinfo(context->m_curlHandle, CURLINFO_RESPONSE_CODE, &responseCode);
response->SetResponseCode(static_cast<HttpResponseCode>(responseCode));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels kinda weird to set response code twice i would prefer if we set it once here, and then assert that its set before leaving the function

@sbera87 sbera87 merged commit 82f91fa into main Jan 14, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants