Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call find_dependency(CURL) if the Curl client is enabled. #2974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented May 28, 2024

Description of changes:

This PR updates the exported config file to call find_dependency(CURL) if the Curl client had been enabled when building the SDK.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review May 28, 2024 11:49
@jmklix
Copy link
Member

jmklix commented Jun 28, 2024

Why exactly do you need this added to the cofig file? This looks like an ok change, but we want to make sure we understand what your use case is

@teo-tsirpanis
Copy link
Contributor Author

aws-cpp-sdk-core sometimes depends on the CURL::libcurl target but until now, that target is not guaranteed to exist. By finding Curl when we find the AWS SDK, we guarantee that the Curl targets exist if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants