test: Increase start-api tests timeouts #7883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerena
changed the title
The start-api tests take longer on Windows, so we increase the timeout so they don't fail.
github-actions
bot
added
pr/external
stage/needs-triage
valerena
force-pushed
the
fix-timeout
branch
from
5f86c5a to
77a53ad
Compare
seshubaws
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start-api tests take longer on Windows, so we increase the timeout so they don't fail.
Which issue(s) does this change fix?
Failure on integration tests.
Why is this change necessary?
Tests were failing just because of a timeout and not because of real problems in the tests. This were all "invalid template" tests, that had a very small timeout, but it depends on the machine where these tests are run.
How does it address the issue?
Increasing the timeout
What side effects does this change have?
If the test were to get stuck forever, it will take longer for the overall test infrastructure to stop this particular test.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.