fix: skip checks on non serverless api resources #6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidhujus
changed the title
hawflau
reviewed
Dec 27, 2023
samcli/commands/deploy/auth_utils.py
Outdated
| @@ -101,6 +101,11 @@ def _auth_id(resources_dict, event_properties, identifier): | |||
| """ | |||
| resource_name = event_properties.get(identifier, "") | |||
| api_resource = resources_dict.get(resource_name, {}) | |||
|
|
|||
| # Auth does not apply to ApiGateway::RestApi resources so return true and continue | |||
| if api_resource and api_resource["Type"] == "AWS::ApiGateway::RestApi": | |||
There was a problem hiding this comment.
Does this apply to AWS::ApiGatewayV2::Api as well?
There was a problem hiding this comment.
Ah yea good catch. I think it should since if the event refers to an httpApi then it would have to be this
mildaniel
reviewed
Jan 2, 2024
hawflau
reviewed
Jan 2, 2024
mildaniel
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6310
Why is this change necessary?
if an api event has a ref to a non serverless api resource we still perform checks as if its a serverless api resource.
How does it address the issue?
skips checking for auth on
Aws::ApiGateway::RestApiresourcesWhat side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.