Skip to content

Commit

Permalink
fix(test): Skip SIGTERM tests on Windows (#6722)
Browse files Browse the repository at this point in the history
* fix(test): Skip SIGTERM tests on Windows

* Format files
  • Loading branch information
mildaniel authored Feb 21, 2024
1 parent 8c1ae4a commit 42ca587
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/integration/local/start_api/test_start_api.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import base64
import shutil
import signal
from unittest import skipIf
import uuid
import random
from pathlib import Path
Expand All @@ -17,6 +18,7 @@

from samcli.commands.local.cli_common.invoke_context import ContainersInitializationMode
from samcli.local.apigw.route import Route
from tests.testing_utils import IS_WINDOWS
from .start_api_integ_base import StartApiIntegBaseClass, WritableStartApiIntegBaseClass
from ..invoke.layer_utils import LayerUtils

Expand Down Expand Up @@ -2161,6 +2163,7 @@ def test_can_invoke_lambda_function_successfully(self):
self.assertEqual(response.json(), {"hello": "world"})


@skipIf(IS_WINDOWS, "SIGTERM interrupt doesn't exist on Windows")
class TestWarmContainersHandlesSigTerm(TestWarmContainersBaseClass):
template_path = "/testdata/start_api/template-warm-containers.yaml"
container_mode = ContainersInitializationMode.EAGER.value
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/local/start_lambda/test_start_lambda.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import signal
from unittest import skipIf
import uuid
from concurrent.futures import ThreadPoolExecutor, as_completed
from time import time, sleep
Expand All @@ -14,6 +15,7 @@
from botocore.exceptions import ClientError

from samcli.commands.local.cli_common.invoke_context import ContainersInitializationMode
from tests.testing_utils import IS_WINDOWS
from .start_lambda_api_integ_base import StartLambdaIntegBaseClass, WatchWarmContainersIntegBaseClass


Expand Down Expand Up @@ -340,6 +342,7 @@ def test_can_invoke_lambda_function_successfully(self):
self.assertEqual(json.loads(response.get("body")), {"hello": "world"})


@skipIf(IS_WINDOWS, "SIGTERM interrupt doesn't exist on Windows")
class TestWarmContainersHandlesSigTermInterrupt(TestWarmContainersBaseClass):
template_path = "/testdata/start_api/template-warm-containers.yaml"
container_mode = ContainersInitializationMode.EAGER.value
Expand Down

0 comments on commit 42ca587

Please sign in to comment.