Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deadline): Add deadline README.md #22

Merged
merged 1 commit into from
Aug 7, 2020
Merged

chore(deadline): Add deadline README.md #22

merged 1 commit into from
Aug 7, 2020

Conversation

jericht
Copy link
Contributor

@jericht jericht commented Jul 30, 2020 •
edited
Loading

Notes

  • Wrote documentation for the deadline module

Testing

  • Rendered the markdown files in VSCode and ensured it looked nice
  • Copy/paste the text in MS Word and ensure there were no spelling errors

Revision

  • 2: Add additional info about RenderQueue encryption and general clean up
  • 3: Fix typo
  • 4: Address CR feedback and "rebase" onto mainline

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jericht jericht requested a review from yashda July 30, 2020 16:33
@jusiskin jusiskin self-requested a review July 30, 2020 16:44
@jericht jericht changed the title chore(deadline): Add documentation about RenderQueue, UBLLicensing, and Docker image recipes WIP: chore(deadline): Add deadline README.md Aug 3, 2020
@jericht jericht self-assigned this Aug 3, 2020
@jericht jericht force-pushed the jericht/deadline_docs branch 2 times, most recently from 1f1623f to a0f0794 Compare August 3, 2020 21:09
@jericht jericht changed the title WIP: chore(deadline): Add deadline README.md chore(deadline): Add deadline README.md Aug 3, 2020
@jericht jericht requested review from ddneilson and removed request for jusiskin August 4, 2020 15:41
@jericht jericht force-pushed the jericht/deadline_docs branch from a0f0794 to 97f36ad Compare August 7, 2020 17:06
@evanspearman-a evanspearman-a self-requested a review August 7, 2020 17:09
evanspearman-a
evanspearman-a requested changes Aug 7, 2020
View reviewed changes
@jericht jericht force-pushed the jericht/deadline_docs branch 3 times, most recently from e6610aa to daa0c75 Compare August 7, 2020 20:11
@jericht jericht force-pushed the jericht/deadline_docs branch from daa0c75 to c1e0b70 Compare August 7, 2020 20:33
@evanspearman-a evanspearman-a self-requested a review August 7, 2020 20:36
evanspearman-a
evanspearman-a approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@evanspearman-a evanspearman-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

yashda
yashda approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@yashda yashda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Thanks for the efforts Jericho!
Ship It!

@evanspearman-a evanspearman-a merged commit 40c3fbb into aws:mainline Aug 7, 2020
@evanspearman-a evanspearman-a deleted the jericht/deadline_docs branch August 7, 2020 20:41
evanspearman-a pushed a commit that referenced this pull request Aug 17, 2020
@jericht @evanspearman-a
chore(deadline): Add README.md for the deadline module (#22)
3d50793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryyakobe ryyakobe ryyakobe left review comments

@yashda yashda yashda approved these changes

@evanspearman-a evanspearman-a evanspearman-a approved these changes

@ddneilson ddneilson Awaiting requested review from ddneilson

Assignees

@jericht jericht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jericht @yashda @ryyakobe @evanspearman-a