fix: do no fail silently when issues occur during publishing #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow is succeeding even though there are issues when publishing to package managers. This is due to the fact that errors were being swallowed due to legacy code that had not been removed. This PR ensures that the respective publish commands do not fail silently anymore.
With respect to the PYPI issue, this is not a bug on our side but rather a limitation on the project size on the PYPI side (default 10GB limit for all releases). I have raised this issue to have this increased to 50Gb: pypi/support#3558
Longer term, we may need to throttle python releases to once per week/month in order to slow the rate at which we will consume this limit.
fix #689