[Bug Fix] Fix ExistingFsxNetworkingValidator #6806
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
reviewed
Apr 30, 2025
| @@ -7,6 +7,8 @@ CHANGELOG | |||
| **CHANGES** | |||
| - Ubuntu 20.04 is no longer supported. | |||
|
|
|||
| **BUG FIXES** | |||
| Fix an issue where Security Group validation failed when a rule contained both IPv4 ranges (IpRanges) and security group references (UserIdGroupPairs). | |||
There was a problem hiding this comment.
Minor: add the - to format the entry as list item.
| return False # Ip Ranges have to be checked later. Return False because the rule allowance is not determined. | ||
| elif rule.get("UserIdGroupPairs"): | ||
| # Ip Ranges have to be checked later. Return False because the rule allowance is not determined. | ||
| if rule.get("UserIdGroupPairs"): |
There was a problem hiding this comment.
Can you please capture this fix into the corresponding unit test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.