Return RegionalHostedZoneId from the cloudformation UI stack #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
requested changes
Feb 6, 2025
| @@ -1109,8 +1109,15 @@ Outputs: | |||
| Condition: UseCustomDomain | |||
| Description: | | |||
| The endpoint associated with the custom domain name. | |||
| Add an A record in your DNS for the PCUI custom domain name pointing to this endpoint. | |||
| Add an A alias record in your DNS for the PCUI custom domain name pointing to this endpoint. | |||
| https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-api-gateway.html#routing-to-api-gateway-config | |||
There was a problem hiding this comment.
We usually do not expose URLs we are not in direct control of as they may change over time.
This URL is owned by the Route53 team, not us.
May you please remove it?
Thanks
| CustomDomainRegionalHostedZoneId: | ||
| Condition: UseCustomDomain | ||
| Description: | | ||
| The region-specific Amazon Route 53 Hosted Zone ID of the regional endpoint. |
There was a problem hiding this comment.
May you please rephrase The Route 53 Hosted Zone ID of the regional endpoint.
"region-specific" is redundant here because of "regional endpoint".
| Value: !GetAtt ApiGatewayCustomDomain.RegionalDomainName | ||
| CustomDomainRegionalHostedZoneId: |
There was a problem hiding this comment.
Why do you need this extra info to configured the DNS?
May you please clarify what's the use case where CustomDomainEndpoint is not enough?
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return RegionalHostedZoneId in outputs of the UI stack as long as this value is needed by Route53 alias
https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-api-gateway.html#routing-to-api-gateway-config
Changes
A new output variable
How Has This Been Tested?
Deployed the UI stack and checked that value exists
PR Quality Checklist
react-i18nextlibrary (useTranslation hook and/or Trans component), see an example herenpm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.