[develop] Change log level to warning when temporarily partial EC2 info #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
from_describe_instance_data
logs a warning and throws an exception. Thefrom_describe_instance_data
is called byfleet_manager.launch_ec2_instances
, but here the instances info are already populated in the_launch_instances
, which calls the_get_instances_info
that does have the retries, by calling_retrieve_instances_info_from_ec2
fleet_manager._retrieve_instances_info_from_ec2
that catch the exceptionIf at the end of the retries there are still instances info with partial data, in the
_launch_instances
these instances are finally logged as error.Tests
References
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.