Add AES CBC cipher to speed.cc #2315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CBC mode which adds more padding
WillChilds-Klein
approved these changes
Apr 8, 2025
| @@ -2875,6 +2877,9 @@ bool Speed(const std::vector<std::string> &args) { | |||
| !SpeedEvpCipherGeneric(EVP_aes_128_ctr(), "EVP-AES-128-CTR", kTLSADLen, selected) || | |||
| !SpeedEvpCipherGeneric(EVP_aes_192_ctr(), "EVP-AES-192-CTR", kTLSADLen, selected) || | |||
| !SpeedEvpCipherGeneric(EVP_aes_256_ctr(), "EVP-AES-256-CTR", kTLSADLen, selected) || | |||
| !SpeedEvpCipherGeneric(EVP_aes_128_cbc(), "EVP-AES-128-CBC", kTLSADLen, selected) || | |||
There was a problem hiding this comment.
what padding is used here? ISO10126 or PKCSv1.5?
Not a concern for this change, but ACCP supports ISO10126 for CBC, and if we could offload that padding to an AWS-LC API, it'd be a nice simplification.
There was a problem hiding this comment.
Turns out this isn't obvious what is used: cipher.h says standard padding is used. Reading the code this uses RFC 5652/PKCS 7 padding (each padding byte value is the number of padding bytes).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
- Coverage 78.77% 78.76% -0.02%
==========================================
Files 620 620
Lines 107757 107757
Branches 15296 15295 -1
==========================================
- Hits 84884 84873 -11
- Misses 22218 22229 +11
Partials 655 655 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing:
Tested locally, will also be covered in CI:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.