Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Docker image for CI integration jobs #2126

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nhatnghiho
Copy link
Contributor

Description of changes:

Install packages needed for running CI integration jobs successfully.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Copy link
Contributor

@andrewhop andrewhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how big is this image now? I'm thinking about how long it will take to pull from ECR and if we want this all in the base or a specific integration test image.

ca-certificates \
sudo \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little weird, can you install sudo into an image that doesn't have it and get it to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops it's an oversight from my side. This is not needed.

@nhatnghiho
Copy link
Contributor Author

nhatnghiho commented Jan 18, 2025

Curious how big is this image now? I'm thinking about how long it will take to pull from ECR and if we want this all in the base or a specific integration test image.

ubuntu-22.04:gcc-12x right now is around 1.05GB, which would be almost a 50% size increase from previously (726MB). I like the idea of creating a separate test image, since a lot of the new packages are quite arbitrary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants