Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align BN_bn2hex behavior with OpenSSL #2122

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

OpenSSL's historically printed BN_bn2hex with upper case letters, as opposed to our original upstream predecessors. We haven't had a concrete ask to change this until recently: ruby/openssl#833.
As most of the open source community and our integration targets still depend on OpenSSL as their main libcrypto dependency, we should consider making the minor adjustment to minimize churn for us and our consumers.

Call-outs:

N/A

Testing:

Tweaks to existing tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.92%. Comparing base (94daeb2) to head (3f8bbe2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2122      +/-   ##
==========================================
- Coverage   78.92%   78.92%   -0.01%     
==========================================
  Files         610      610              
  Lines      105137   105137              
  Branches    14911    14910       -1     
==========================================
- Hits        82983    82976       -7     
- Misses      21503    21510       +7     
  Partials      651      651              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 merged commit 232b7b3 into aws:main Jan 16, 2025
123 of 126 checks passed
@samuel40791765 samuel40791765 deleted the bn-upper branch January 16, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants