-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ed25519ph and Ed25519ctx Support #2120
base: main
Are you sure you want to change the base?
Conversation
c2407bc
to
dce8cd8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
========================================
Coverage 78.92% 78.93%
========================================
Files 610 610
Lines 105137 105270 +133
Branches 14911 14923 +12
========================================
+ Hits 82983 83094 +111
- Misses 21503 21522 +19
- Partials 651 654 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General notes:
- Missing service indicator tests for approved ph and unapproved ctx
- Missing ACVP demo vectors
- Double checking: can these new singing modes rely on the existing boringssl_ensure_eddsa_self_test or do we need a new ctx/ph specific self test?
dce8cd8
to
d310345
Compare
d310345
to
6ad9e7d
Compare
Addressed all outstanding comments and remaining work items. |
ea8cd36
to
dbd0146
Compare
dbd0146
to
b5a7f2e
Compare
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.