Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed25519ph and Ed25519ctx Support #2120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jan 15, 2025

Description of changes:

  • Add support for Ed25519ph and Ed25519ph where the digest is pre-computed and provided externally.
  • Add support for Ed25519ctx from RFC 8032.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner January 15, 2025 01:41
@skmcgrail skmcgrail requested a review from nebeid January 15, 2025 01:42
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.58974% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (94daeb2) to head (dce8cd8).

Files with missing lines Patch % Lines
crypto/fipsmodule/curve25519/curve25519.c 91.58% 9 Missing ⚠️
crypto/fipsmodule/curve25519/ed25519_test.cc 97.22% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2120    +/-   ##
========================================
  Coverage   78.92%   78.93%            
========================================
  Files         610      610            
  Lines      105137   105270   +133     
  Branches    14911    14923    +12     
========================================
+ Hits        82983    83094   +111     
- Misses      21503    21522    +19     
- Partials      651      654     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewhop andrewhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General notes:

  1. Missing service indicator tests for approved ph and unapproved ctx
  2. Missing ACVP demo vectors
  3. Double checking: can these new singing modes rely on the existing boringssl_ensure_eddsa_self_test or do we need a new ctx/ph specific self test?

include/openssl/curve25519.h Outdated Show resolved Hide resolved
crypto/fipsmodule/curve25519/ed25519ctx_tests.txt Outdated Show resolved Hide resolved
crypto/fipsmodule/curve25519/ed25519_test.cc Outdated Show resolved Hide resolved
include/openssl/curve25519.h Outdated Show resolved Hide resolved
include/openssl/curve25519.h Outdated Show resolved Hide resolved
crypto/fipsmodule/curve25519/curve25519.c Outdated Show resolved Hide resolved
crypto/fipsmodule/curve25519/curve25519.c Outdated Show resolved Hide resolved
@skmcgrail
Copy link
Member Author

Addressed all outstanding comments and remaining work items.

@skmcgrail skmcgrail force-pushed the ed25519ph-ll branch 2 times, most recently from ea8cd36 to dbd0146 Compare January 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants