Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enable_dilithium flag #2105

Closed
wants to merge 8 commits into from
Closed

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Jan 10, 2025

Do not merge yet -- build on top of #2104

Issues:

Resolves #CryptoAlg-2827

Description of changes:

  • Removed the enable_dilithium flag

Call-outs:

  • The build flag still exists but now has no functionality in the library (safe removal)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@jakemas jakemas requested a review from a team as a code owner January 10, 2025 20:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.91%. Comparing base (5084e19) to head (a33dc5d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
+ Coverage   78.77%   78.91%   +0.14%     
==========================================
  Files         598      610      +12     
  Lines      103656   105119    +1463     
  Branches    14719    14902     +183     
==========================================
+ Hits        81650    82956    +1306     
- Misses      21354    21510     +156     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakemas jakemas closed this Jan 10, 2025
@jakemas
Copy link
Contributor Author

jakemas commented Jan 10, 2025

#2106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants