Fix SSL_get_ciphers behavior to return TLS 1.3 ciphersuites #2092
+208
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2559
Description of changes:
SSL_CTX_new
now configuresctx->tls13_cipher_suites
with default TLS 1.3 ciphers (did not previously)ctx->cipher_list
is updated with values fromctx->tls13_cipher_suites
via a new functionupdate_cipher_list
. This function also updates in_group_flags.Call-outs:
In general, our TLS implementations pick ciphersuites against the given connection constraints/parameters. Adding TLS 1.3 ciphersuites to
ctx->cipher_list
does not modify this behavior or introduce new problems.Testing:
Added tests to ensure TLS 1.3 ciphersuites are returned as configured when calling SSL_get_ciphers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.