Migrate 2nd batch of CI jobs #2091
Conversation
nhatnghiho
force-pushed
the
codebuild-ci-migration
branch
from
f2a1f6d to
6c703b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
- Coverage 78.77% 78.77% -0.01%
==========================================
Files 598 598
Lines 103744 103653 -91
Branches 14735 14720 -15
==========================================
- Hits 81726 81649 -77
+ Misses 21366 21353 -13
+ Partials 652 651 -1 ☔ View full report in Codecov by Sentry. |
|
Should the corresponding GitHub CI workflows be removed in this PR, or in a subsequent one? |
| variables: | ||
| AWS_LC_CI_TARGET: "tests/ci/integration/run_openldap_integration.sh" | ||
| OPENLDAP_BRANCH: "master" | ||
| OPENLDAP_RELEASE: "OPENLDAP_REL_ENG_2_5" |
There was a problem hiding this comment.
I wonder whether by removing the quotes here we would be able to pass arguments directly to the script, instead of setting environment variables?
phases:
build:
commands:
- ./${AWS_LC_CI_TARGET}
There was a problem hiding this comment.
I'll try this out. I was trying to avoid clumping the arguments to AWS_LC_CI_TARGET since it's not very neat
It's in this PR. Just pushed it |
nhatnghiho
force-pushed
the
codebuild-ci-migration
branch
from
728af54 to
2d4b00d
Compare
Description of changes:
Migrate the following jobs from
integrations.ymlto CodeBuild:openldapcyrus-sasllibeventBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.