Ci fixes from main 13122024 #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [recent commit](python/cpython@b105157#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621L4927) in python 3.13 broke our patch. This fixes it.
Current integration patch fails to apply on the latest nginx v1.27.3. Updated patch file aligns with the latest nginx v1.27.3 code changes.
The CI issues we've been having stems from some new tests tcpdump has for the upcoming 2038 problem. However, these tests will fail with outdated versions of libpcap that don't support the preprocessor macro `_TIME_BITS` (Documented in the-tcpdump-group/tcpdump#1147) **Tcpdump's fixed the issue when running release-check: the-tcpdump-group/tcpdump@0546e6a. Release-check already runs with check and runs all the tests, but with a more defined process.** Since upstream's just running release-check to encapsulate everything, I think we can just run release-check here to get rid of CI issues. ### Call-outs: N/A ### Testing: CI By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Alpine Linux has started using gcc-14 as the default compiler. This is broken with our FIPS build which has started causing CI failures. See aws#2010 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
dkostic
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #2059 +/- ##
=========================================================
- Coverage 78.72% 78.71% -0.01%
=========================================================
Files 608 608
Lines 102774 102774
Branches 14582 14581 -1
=========================================================
- Hits 80907 80903 -4
- Misses 21159 21160 +1
- Partials 708 711 +3 ☔ View full report in Codecov by Sentry. |
samuel40791765
approved these changes
Dec 14, 2024
torben-hansen
merged commit 4d2b576
into
aws:randomness_generation
115 of 116 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking
d6a4786
a47d28b
9d62ff2
a89cb97
850af98
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.