[EC] Use s2n-bignum's modular inversion for P-256/384/521 #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 10, 2024 19:48
This reverts commit 86bee87.
dkostic
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 78.76% 78.74% -0.02%
==========================================
Files 598 598
Lines 103688 103655 -33
Branches 14742 14733 -9
==========================================
- Hits 81666 81627 -39
- Misses 21369 21374 +5
- Partials 653 654 +1 ☔ View full report in Codecov by Sentry. |
andrewhop
previously approved these changes
Dec 16, 2024
nebeid
reviewed
Dec 16, 2024
| @@ -63,6 +63,8 @@ static inline void p256_montjscalarmul_selector(uint64_t res[S2N_BIGNUM_STATIC 1 | |||
| else { p256_montjscalarmul(res, scalar, point); } | |||
| } | |||
|
|
|||
| extern void bignum_montinv_p256(uint64_t z[S2N_BIGNUM_STATIC 4], const uint64_t x[S2N_BIGNUM_STATIC 4]); | |||
There was a problem hiding this comment.
Can we document what the function does and that it's constant-time?
andrewhop
approved these changes
Dec 17, 2024
nebeid
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Use s2n-bignum's inversion modulo the field characteristic
for curves P-256/384/521. This gives us the following
performance improvements:
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.