Integrate ube for rand engine #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #1897 +/- ##
=========================================================
+ Coverage 78.42% 78.46% +0.04%
=========================================================
Files 585 585
Lines 97020 97060 +40
Branches 13903 13919 +16
=========================================================
+ Hits 76090 76162 +72
+ Misses 20311 20282 -29
+ Partials 619 616 -3 ☔ View full report in Codecov by Sentry. |
andrewhop
reviewed
Oct 4, 2024
dkostic
reviewed
Oct 10, 2024
dkostic
approved these changes
Oct 11, 2024
andrewhop
approved these changes
Oct 11, 2024
| @@ -252,7 +293,7 @@ static void RAND_bytes_core( | |||
|
|
|||
| OPENSSL_cleanse(pred_resistance, RAND_PRED_RESISTANCE_LEN); | |||
|
|
|||
| if (rand_ensure_valid_state() != 1) { | |||
| if (rand_ensure_valid_state(state) != 1) { | |||
There was a problem hiding this comment.
NP: in a future PR can you add a comment here explaining why we need to abort. I get that it means a UBE occurred and if that happened after line 235 and before line 242 you could end up with duplicate state, we might just forget/think this looks weird in the future.
torben-hansen
merged commit ccb97ef
into
aws:randomness_generation
101 of 106 checks passed
torben-hansen
added a commit
to torben-hansen/aws-lc
that referenced
this pull request
Nov 1, 2024
This PR integrates protection of the thread-local state into the new randomness generation implementation. rand_ensure_ctr_drbg_uniquness() is the function that determines whether a randomization of the thread-local state is necessary. rand_ensure_ctr_drbg_uniquness() is called inline in the core randomness generation code path (in RAND_bytes_core() and invoked on every entry. The only mechanism currently implemented that can force a randomization is the UBE mechanism implemented in bc7aeff. Note that if UBE is "unavailable" then a randomization is forced every time.
torben-hansen
added a commit
to torben-hansen/aws-lc
that referenced
this pull request
Dec 13, 2024
This PR integrates protection of the thread-local state into the new randomness generation implementation. rand_ensure_ctr_drbg_uniquness() is the function that determines whether a randomization of the thread-local state is necessary. rand_ensure_ctr_drbg_uniquness() is called inline in the core randomness generation code path (in RAND_bytes_core() and invoked on every entry. The only mechanism currently implemented that can force a randomization is the UBE mechanism implemented in bc7aeff. Note that if UBE is "unavailable" then a randomization is forced every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR integrates protection of the thread-local state into the new randomness generation implementation.
rand_ensure_ctr_drbg_uniquness()is the function that determines whether a randomization of the thread-local state is necessary.rand_ensure_ctr_drbg_uniquness()is called inline in the core randomness generation code path (inRAND_bytes_core()and invoked on every entry.The only mechanism currently implemented that can force a randomization is the UBE mechanism implemented in bc7aeff. Note that if UBE is "unavailable" then a randomization is forced every time.
Testing:
Some additional support code is implemented to mock the UBE detection and determine if correct behaviour occurred.
The failing tests are because the target branch is
randomness_generationthat haven't been rebased onmainbranch with fixes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.