Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of EVP_PKEY_CTX_ctrl_str for various key types #1850

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

Implementation of EVP_PKEY_CTX_ctrl_str for various key types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 13, 2024 16:39
@justsmth justsmth force-pushed the EVP_PKEY_CTX_ctrl_str-Impls branch from c086e9e to 38f7542 Compare September 13, 2024 16:41
@justsmth justsmth changed the title Evp pkey ctx ctrl str impls Implementation of EVP_PKEY_CTX_ctrl_str for various key types Sep 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 89.32039% with 22 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (9d21f38) to head (f19df5a).

Files with missing lines Patch % Lines
crypto/fipsmodule/evp/p_hkdf.c 80.85% 9 Missing ⚠️
crypto/fipsmodule/evp/p_ec.c 72.22% 5 Missing ⚠️
crypto/evp_extra/p_dh.c 66.66% 3 Missing ⚠️
crypto/fipsmodule/evp/p_rsa.c 94.64% 3 Missing ⚠️
crypto/fipsmodule/evp/evp_ctx_test.cc 97.26% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   78.51%   78.62%   +0.10%     
==========================================
  Files         583      584       +1     
  Lines       98809    99018     +209     
  Branches    14159    14205      +46     
==========================================
+ Hits        77583    77856     +273     
+ Misses      20598    20530      -68     
- Partials      628      632       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the EVP_PKEY_CTX_ctrl_str-Impls branch 2 times, most recently from 60ca7c3 to d464647 Compare September 13, 2024 18:40
crypto/fipsmodule/evp/p_rsa.c Outdated Show resolved Hide resolved
crypto/evp_extra/p_dh.c Show resolved Hide resolved
crypto/fipsmodule/evp/p_ec.c Show resolved Hide resolved
crypto/fipsmodule/evp/p_ec.c Outdated Show resolved Hide resolved
crypto/fipsmodule/evp/p_rsa.c Outdated Show resolved Hide resolved
crypto/fipsmodule/evp/p_hkdf.c Outdated Show resolved Hide resolved
@justsmth justsmth force-pushed the EVP_PKEY_CTX_ctrl_str-Impls branch 4 times, most recently from 49d49c1 to 0d80065 Compare September 16, 2024 18:43
@justsmth justsmth force-pushed the EVP_PKEY_CTX_ctrl_str-Impls branch from 0d80065 to f19df5a Compare September 17, 2024 15:19
@justsmth justsmth enabled auto-merge (squash) September 17, 2024 16:43
crypto/evp_extra/p_dh.c Show resolved Hide resolved
crypto/fipsmodule/evp/p_hkdf.c Show resolved Hide resolved
crypto/fipsmodule/evp/p_rsa.c Show resolved Hide resolved
@justsmth justsmth merged commit c1b5d85 into aws:main Sep 17, 2024
109 of 110 checks passed
smittals2 added a commit that referenced this pull request Sep 19, 2024
## What's Changed
* More tweaks for Ruby integration by @samuel40791765 in
#1852
* Implementation of EVP_PKEY_CTX_ctrl_str for various key types by
@justsmth in #1850
* Add MLKEM768 Hybrid Groups to libssl by @alexw91 in
#1849
* add support for PEM_write_bio_PrivateKey_traditional by
@samuel40791765 in #1845
* Update s2n-bignum subtree by @torben-hansen in
#1861
* Add asserts in testing to fix Coverity alert by @smittals2 in
#1864
* Disable CRYPTO_is_AVX512IFMA_capable by @justsmth in
#1858


**Full Changelog**:
v1.35.0...v1.35.1

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants