Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ret to NULL before return in EC_POINT_bn2point #1692

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

samuel40791765
Copy link
Contributor

Issues:

Resolves P138896891

Description of changes:

Static analysis was complaining about us using the pointer after it was freed. I don't believe this is an actual "issue", but we might as well make the NULL explicit before returning.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested review from dkostic and nebeid July 8, 2024 20:38
@samuel40791765 samuel40791765 requested a review from a team as a code owner July 8, 2024 20:38
@samuel40791765 samuel40791765 changed the title Set ret to NULL before return Set ret to NULL before return in EC_POINT_bn2point Jul 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (00fcba4) to head (d488ff7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files         571      571           
  Lines       95464    95465    +1     
  Branches    13703    13704    +1     
=======================================
+ Hits        74656    74659    +3     
+ Misses      20197    20194    -3     
- Partials      611      612    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 merged commit 622366f into aws:main Jul 9, 2024
98 of 100 checks passed
@samuel40791765 samuel40791765 deleted the null-free branch July 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants