Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ECPKParameters_print as no-op #1686

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

samuel40791765
Copy link
Contributor

Issues:

Resolves CryptoAlg-1715

Description of changes:

Ruby consumes ECPKParameters_print. The entire function is a bit convoluted and not really beneficial unless you're using custom curves. We can expose this as a no-op until there's a more proper use case for this.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner July 2, 2024 00:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (622366f) to head (06b8672).

Files Patch % Lines
crypto/ec_extra/ec_asn1.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1686   +/-   ##
=======================================
  Coverage   78.19%   78.20%           
=======================================
  Files         571      571           
  Lines       95465    95467    +2     
  Branches    13704    13711    +7     
=======================================
+ Hits        74653    74662    +9     
+ Misses      20201    20193    -8     
- Partials      611      612    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/openssl/ec.h Outdated Show resolved Hide resolved
@samuel40791765 samuel40791765 force-pushed the ecpk-parameters-print branch from baff41f to 06b8672 Compare July 9, 2024 19:27
@samuel40791765 samuel40791765 merged commit a0e8da9 into aws:main Jul 11, 2024
99 of 100 checks passed
@samuel40791765 samuel40791765 deleted the ecpk-parameters-print branch July 11, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants