-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapsafe-type uniqueness breaking event detection #1640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
snap-safe
branch
2 times, most recently
from
June 17, 2024 21:46
862776d
to
65e631f
Compare
andrewhop
reviewed
Jun 17, 2024
justsmth
changed the title
[DRAFT] Snapsafe-type uniqueness breaking event detection
Snapsafe-type uniqueness breaking event detection
Jun 18, 2024
justsmth
force-pushed
the
snap-safe
branch
2 times, most recently
from
June 18, 2024 16:55
58ad6b2
to
b2a37c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to review crypto/fipsmodule/rand/snapsafe_*
andrewhop
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core change looks good to me, ship it pending urandom test fix.
justsmth
force-pushed
the
snap-safe
branch
2 times, most recently
from
June 19, 2024 00:13
de6ed05
to
afd1ac0
Compare
justsmth
force-pushed
the
snap-safe
branch
3 times, most recently
from
June 19, 2024 01:03
f247920
to
de1ea99
Compare
justsmth
force-pushed
the
snap-safe
branch
7 times, most recently
from
June 19, 2024 16:36
4d70027
to
044c69d
Compare
Co-authored-by: torben-hansen <[email protected]>
torben-hansen
previously approved these changes
Jun 19, 2024
Co-authored-by: torben-hansen <[email protected]>
torben-hansen
approved these changes
Jun 19, 2024
dkostic
approved these changes
Jun 20, 2024
justsmth
added a commit
to justsmth/aws-lc
that referenced
this pull request
Jun 20, 2024
(cherry picked from commit f31fd31)
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Description of changes:
/dev/sysgenid
). Adds 4 new (internal-use) functions:int CRYPTO_get_snapsafe_generation(uint32_t *snapsafe_generation_number);
int CRYPTO_get_snapsafe_active(void);
int CRYPTO_get_snapsafe_supported(void);
const char *CRYPTO_get_sysgenid_path(void);
Call-outs:
New build flags added:
TEST_SYSGENID_PATH
-- a temporary file path that will be used for testing. The user executing the test must have permission read/write to this path and it must be created prior to running the tests.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.