Add EVP_md_null and SSL_set_ciphersuites #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
force-pushed
the
openldap-integration
branch
from
c60c5b5 to
7ffa19f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
- Coverage 78.16% 78.16% -0.01%
==========================================
Files 562 562
Lines 94683 94693 +10
Branches 13575 13575
==========================================
+ Hits 74008 74014 +6
- Misses 20082 20084 +2
- Partials 593 595 +2 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
force-pushed
the
openldap-integration
branch
2 times, most recently
from
8682dc7 to
ebb981c
Compare
smittals2
reviewed
Jun 19, 2024
smittals2
previously approved these changes
Jun 19, 2024
This commit adds two functions used by OpenLDAP 2.5.17+. Both functions are very straightforward. From OpenSSL's [docs][1] for `EVP_md_null`: >A "null" message digest that does nothing: i.e. the hash it returns is of zero length. From OpenSSL's [docs][2] for `SSL_set_ciphersuites`: > SSL_set_ciphersuites() is the same as SSL_CTX_set_ciphersuites() except it configures the ciphersuites for ssl. [1]: https://www.openssl.org/docs/man1.1.1/man3/EVP_md_null.html [2]: https://www.openssl.org/docs/man1.1.1/man3/SSL_set_ciphersuites.html
WillChilds-Klein
force-pushed
the
openldap-integration
branch
from
8d29f7f to
ef7e6ee
Compare
samuel40791765
approved these changes
Jun 19, 2024
smittals2
approved these changes
Jun 19, 2024
WillChilds-Klein
added a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Jun 20, 2024
**NOTE:** All changes in this commit are outside of the FIPS module boundary and as such do not affect the module hash. This commit adds two functions used by OpenLDAP 2.5.17+. Both functions are very straightforward. From OpenSSL's [docs][1] for `EVP_md_null`: >A "null" message digest that does nothing: i.e. the hash it returns is of zero length. From OpenSSL's [docs][2] for `SSL_set_ciphersuites`: > SSL_set_ciphersuites() is the same as SSL_CTX_set_ciphersuites() except it configures the ciphersuites for ssl. [1]: https://www.openssl.org/docs/man1.1.1/man3/EVP_md_null.html [2]: https://www.openssl.org/docs/man1.1.1/man3/SSL_set_ciphersuites.html
justsmth
pushed a commit
that referenced
this pull request
Jun 21, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-2464
Description of changes:
This commit adds two functions used by OpenLDAP 2.5.17+. Both functions are very straightforward.
From OpenSSL's docs for
EVP_md_null:From OpenSSL's docs for
SSL_set_ciphersuites:Call-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.