Replace inject_hash.go with C inject_hash on MacOS #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
- Coverage 78.33% 78.33% -0.01%
==========================================
Files 580 580
Lines 97255 97255
Branches 13946 13946
==========================================
- Hits 76187 76181 -6
- Misses 20447 20453 +6
Partials 621 621 ☔ View full report in Codecov by Sentry. |
billbo-yang
force-pushed
the
new_inject_hash
branch
2 times, most recently
from
5fea59c to
ef94361
Compare
billbo-yang
force-pushed
the
new_inject_hash
branch
from
ef94361 to
a61d352
Compare
billbo-yang
force-pushed
the
new_inject_hash
branch
from
34f9521 to
b0ee741
Compare
added 20 commits
August 23, 2024 07:57
added 9 commits
August 23, 2024 07:57
justsmth
force-pushed
the
new_inject_hash
branch
from
7ab589b to
3a234cc
Compare
justsmth
force-pushed
the
new_inject_hash
branch
from
3a234cc to
1f846c5
Compare
|
I pushed a commit that did some minor "cleanup" here: 1f846c5 |
justsmth
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-2240
Description of changes:
Replaces the use of inject_hash.go with a C version of the script on MacOS as a first step to removing inject_hash.go entirely.
Putting up as a draft first so I can ensure that it builds on all platforms.
Testing:
Tests pass locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.