Slight build fix and migrate to GHA for MacOS ARM CI #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
os-arm-ci
branch
from
e60d6bd to
4ceaf2b
Compare
samuel40791765
changed the title
skmcgrail
reviewed
Oct 13, 2023
samuel40791765
force-pushed
the
os-arm-ci
branch
from
ac7d594 to
3d19c2e
Compare
skmcgrail
approved these changes
Oct 16, 2023
justsmth
approved these changes
Oct 17, 2023
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Oct 17, 2023
The FIPS Shared build on MacOSX wasn't working if OSX_VERSION_MIN_FLAG wasn't defined, so this fixes that. Github Actions also finally released MacOS ARM runners. We can deprecate the Codebuild->SSM->ec2 workaround for now.
Merged
justsmth
pushed a commit
to justsmth/aws-lc
that referenced
this pull request
Jan 12, 2024
The FIPS Shared build on MacOSX wasn't working if OSX_VERSION_MIN_FLAG wasn't defined, so this fixes that. Github Actions also finally released MacOS ARM runners. We can deprecate the Codebuild->SSM->ec2 workaround for now. FIPS-2022-11-02: Only took changes to `crypto/fipsmodule/CMakeLists.txt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.