Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad cast in SSHKDF #1241

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix bad cast in SSHKDF #1241

merged 1 commit into from
Oct 11, 2023

Conversation

justsmth
Copy link
Contributor

Issues:

N/A

Description of changes:

  • Bad cast was causing SSHKDF to break on ppc64be.
    • The [third parameter of EVP_DigestFinal_ex]
      OPENSSL_EXPORT int EVP_DigestFinal_ex(EVP_MD_CTX *ctx, uint8_t *md_out,
      is expected to be an unsigned int *, but a size_t* was being passed.

Call-outs:

N/A

Testing:

❯ ppc64-qemu.sh ./crypto/crypto_test --gtest_filter="SSHKDFTest.*"  
Note: Google Test filter = SSHKDFTest.*
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from SSHKDFTest
[ RUN      ] SSHKDFTest.SSHKDF_INPUT_INSANITY
[       OK ] SSHKDFTest.SSHKDF_INPUT_INSANITY (3 ms)
[ RUN      ] SSHKDFTest.KAT
[       OK ] SSHKDFTest.KAT (388 ms)
[----------] 2 tests from SSHKDFTest (393 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (401 ms total)
[  PASSED  ] 2 tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner October 11, 2023 15:09
@justsmth justsmth requested a review from Taffer October 11, 2023 15:15
@justsmth justsmth merged commit ed4e08f into aws:main Oct 11, 2023
@justsmth justsmth deleted the fix-sshkdf branch October 11, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants