-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for Windows MSVC2019, MSVC2022, and SDE 32/64-bit #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
windows-sde
branch
from
October 6, 2023 22:24
bbf4687
to
0c08f93
Compare
Tests are slow and insufficient memory on the instance causes the tests to fail in Codebuild.. A single test run takes nearly 2 hours on the beefiest instance too.
For a better picture, it took me 50ish minutes to finish one run on a z1d.metal instance I spun up. |
samuel40791765
force-pushed
the
windows-sde
branch
28 times, most recently
from
October 10, 2023 23:49
7acd002
to
0295da9
Compare
samuel40791765
changed the title
Add CI dimension for Windows SDE 32 and 64 bit
Add CI dimensions for Windows MSVC2019, MSVC2022, and SDE 32/64-bit
Oct 13, 2023
samuel40791765
changed the title
Add CI dimensions for Windows MSVC2019, MSVC2022, and SDE 32/64-bit
Add CI for Windows MSVC2019, MSVC2022, and SDE 32/64-bit
Oct 13, 2023
samuel40791765
force-pushed
the
windows-sde
branch
2 times, most recently
from
October 16, 2023 15:29
6a44406
to
5030753
Compare
samuel40791765
force-pushed
the
windows-sde
branch
from
October 17, 2023 19:57
5030753
to
4eb2914
Compare
andrewhop
reviewed
Oct 18, 2023
andrewhop
previously approved these changes
Oct 20, 2023
samuel40791765
force-pushed
the
windows-sde
branch
from
October 23, 2023 16:02
2cf1c32
to
b0ac612
Compare
skmcgrail
approved these changes
Oct 23, 2023
samuel40791765
force-pushed
the
windows-sde
branch
from
October 23, 2023 23:36
b0ac612
to
41e0085
Compare
andrewhop
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-2094
Description of changes:
CryptoAlg-2137
to investigate.Call-outs:
Unsure how slow the Windows SDE tests will be in Codebuild.
Testing:
New CI dimension
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.