Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Windows MSVC2019, MSVC2022, and SDE 32/64-bit #1228

Merged
merged 11 commits into from
Oct 24, 2023

Conversation

samuel40791765
Copy link
Contributor

@samuel40791765 samuel40791765 commented Oct 6, 2023

Issues:

Resolves CryptoAlg-2094

Description of changes:

  • This creates a CI dimension for Windows 32 and 64 bit SDE. Windows scripts were refactored to be more generic as well.
  • We test with the Windows SDE with the MSVC2019 build.
  • SHA256 dispatch test fails for some reason on the Debug build with newer processors when building for 32-bit. Our digest tests still pass though, so it could just be some wrong assumptions. I've punted CryptoAlg-2137 to investigate.
  • I also discovered how to properly build with MSVC2019 and MSVC2022 while working on this, so I added CI for the two compilers as well.
  • Tested all dimensions against appropriate instance sizes.
    • SDE tests take 90ish minutes to finish on 32 cores. We try to fit our CI within 1 hour, so I went with the next largest instance.
    • Github provided Windows instances only have 2 cores and aren't sufficient enough for our regular Windows tests. The next larger instance was 8 cores, so I went with that.

Call-outs:

Unsure how slow the Windows SDE tests will be in Codebuild.

Testing:

New CI dimension

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765
Copy link
Contributor Author

samuel40791765 commented Oct 6, 2023

Tests are slow and insufficient memory on the instance causes the tests to fail in Codebuild.. A single test run takes nearly 2 hours on the beefiest instance too.

[ RUN      ] BIOTest.Gets
[       OK ] BIOTest.Gets (364 ms)
[ RUN      ] BIOTest.InvokeConnectCallback
new[] failed to allocate 131072 bytes
crypto/crypto_test (for CPU "bdw")
crypto/crypto_test failed to complete: exit status 0xffffffff

For a better picture, it took me 50ish minutes to finish one run on a z1d.metal instance I spun up.

@samuel40791765 samuel40791765 force-pushed the windows-sde branch 28 times, most recently from 7acd002 to 0295da9 Compare October 10, 2023 23:49
@samuel40791765 samuel40791765 marked this pull request as ready for review October 13, 2023 20:41
@samuel40791765 samuel40791765 requested a review from a team as a code owner October 13, 2023 20:41
@samuel40791765 samuel40791765 changed the title Add CI dimension for Windows SDE 32 and 64 bit Add CI dimensions for Windows MSVC2019, MSVC2022, and SDE 32/64-bit Oct 13, 2023
@samuel40791765 samuel40791765 changed the title Add CI dimensions for Windows MSVC2019, MSVC2022, and SDE 32/64-bit Add CI for Windows MSVC2019, MSVC2022, and SDE 32/64-bit Oct 13, 2023
@samuel40791765 samuel40791765 force-pushed the windows-sde branch 2 times, most recently from 6a44406 to 5030753 Compare October 16, 2023 15:29
@skmcgrail skmcgrail self-requested a review October 16, 2023 17:46
.github/workflows/windows.yml Outdated Show resolved Hide resolved
util/all_tests.json Outdated Show resolved Hide resolved
andrewhop
andrewhop previously approved these changes Oct 20, 2023
@samuel40791765 samuel40791765 enabled auto-merge (squash) October 24, 2023 00:34
@samuel40791765 samuel40791765 merged commit 265984e into aws:main Oct 24, 2023
@samuel40791765 samuel40791765 deleted the windows-sde branch December 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants