Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppleClang 15 FIPS Shared Library Build #1224

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Oct 5, 2023

Issues:

Resolves CryptoAlg-1686

Description of changes:

  • Fixes the linking warnings seen previously
ld: warning: object file (/Users/runner/work/aws-lc/aws-lc/test_build_dir/crypto/fipsmodule/libbcm_library.a(bcm.c.o)) was built for newer macOS version (11.7) than being linked (11.0)
  • There is a behavior change in AppleClang that is resulting in debugging symbols (GDB stabs) appearing for the _BORINGSSL_bcm_text_start and _BORINGSSL_bcm_rodata_start symbols. This updates the inject-hash utility to skip Mach-O symbols that are flagged with one or more of the debugging type bits.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner October 5, 2023 18:49
@skmcgrail skmcgrail changed the title Fix AppleClang 15 FIPS Shared Build Fix AppleClang 15 FIPS Shared Library Build Oct 5, 2023
justsmth
justsmth previously approved these changes Oct 5, 2023
util/fipstools/inject_hash/inject_hash.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit cb9022d into aws:main Oct 9, 2023
@skmcgrail skmcgrail deleted the apple-clang-15-fixes branch October 9, 2023 19:18
billbo-yang pushed a commit to billbo-yang/aws-lc that referenced this pull request Oct 9, 2023
andrewhop pushed a commit to andrewhop/aws-lc that referenced this pull request Oct 13, 2023
justsmth pushed a commit to justsmth/aws-lc that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants