Abstract some ec2 CI logic and add support for c7g #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed the name of "aws-lc-ci-macos-arm" to "aws-lc-ci-ec2-test-framework". That build batch won't be kicked off until we apply this change :). |
billbo-yang
reviewed
Oct 3, 2023
billbo-yang
previously approved these changes
Oct 3, 2023
skmcgrail
reviewed
Oct 3, 2023
skmcgrail
reviewed
Oct 3, 2023
| @@ -50,8 +50,8 @@ | |||
| AwsLcGitHubAnalyticsStack(app, "aws-lc-ci-analytics", analytics_build_spec_file, env=env) | |||
| # bm_framework_build_spec_file = "cdk/codebuild/bm_framework_omnibus.yaml" | |||
| # BmFrameworkStack(app, "aws-lc-ci-bm-framework", bm_framework_build_spec_file, env=env) | |||
| mac_arm_build_spec_file = "cdk/codebuild/github_ci_macos_m1_omnibus.yaml" | |||
| AwsLcMacArmCIStack(app, "aws-lc-ci-macos-arm", mac_arm_build_spec_file, env=env) | |||
| ec2_test_framework_build_spec_file = "cdk/codebuild/ec2_test_framework_omnibus.yaml" | |||
There was a problem hiding this comment.
I can't remember, but I think we will need to remember to manually terminate this stack. It looks like the resources created in it are all unique I believe? Don't believe CDK will handle this for us in this instance.
There was a problem hiding this comment.
Yeah good call. I had to delete the original stack in my local fork, so the same should be applicable here as well. Also might have to apply this change to the FIPS branches as well or they'll still be calling the old stack.
samuel40791765
force-pushed
the
graviton3-ci
branch
from
f05f75b to
8314e86
Compare
skmcgrail
approved these changes
Oct 5, 2023
samuel40791765
force-pushed
the
graviton3-ci
branch
from
8314e86 to
c6dea97
Compare
billbo-yang
approved these changes
Oct 6, 2023
billbo-yang
pushed a commit
to billbo-yang/aws-lc
that referenced
this pull request
Oct 9, 2023
This extends the M1 Mac CI framework to encapsulate specific ec2 instances we want to test against.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-1121Description of changes:
We're looking to strengthen our CI coverage. This extends the M1 Mac CI framework to encapsulate specific ec2 instances we want to test against. Things are slightly different than M1 however. M1 instances need to be allocated for at least 24 hours, while these instances can be spun up and terminated on the fly.
Call-outs:
This, again, borrows a lot of code from our original benchmarking framework. Scripts and SSM document were taken from:
Testing:
CI changes are tested and can be seen in a PR on my local fork:
See: AWS CodeBuild BuildBatch us-west-2 (aws-lc-ci-ec2-test-framework)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.