Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images for loongarch64, ppc64, ppc64le, and riscv64 #1168

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

justsmth
Copy link
Contributor

Issues:

N/A

Description of changes:

  • Add docker images to improve support for other architectures: ppc64, ppc64le, and riscv64

Call-outs:

N/A

Testing:

  • Images have been built/tested on Mac and Linux (x86-64).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner August 25, 2023 14:14
@justsmth justsmth marked this pull request as draft August 25, 2023 15:56
Copy link
Contributor

@nebeid nebeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that these images may be moved from under CI since they won't be integrated in CI in this PR.

@justsmth justsmth force-pushed the arch-support branch 4 times, most recently from 35a91b3 to d0b0643 Compare September 1, 2023 13:51
@justsmth justsmth changed the title Docker images for ppc64, ppc64le, and riscv64 Docker images for loongarch64, ppc64, ppc64le, and riscv64 Sep 1, 2023
@justsmth justsmth force-pushed the arch-support branch 3 times, most recently from 3954c14 to 44f57d2 Compare September 5, 2023 15:56
@andrewhop andrewhop self-requested a review September 5, 2023 17:27
@andrewhop andrewhop marked this pull request as ready for review September 5, 2023 17:27
@justsmth justsmth force-pushed the arch-support branch 4 times, most recently from a6897a9 to 5dd58ac Compare October 5, 2023 17:57
@nebeid nebeid self-requested a review October 24, 2023 17:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b15b9d3) 77.96% compared to head (a83655e) 77.95%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   77.96%   77.95%   -0.01%     
==========================================
  Files         530      530              
  Lines      101077   101074       -3     
==========================================
- Hits        78805    78794      -11     
- Misses      22272    22280       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkostic dkostic merged commit 52deb61 into aws:main Nov 28, 2023
13 checks passed
@justsmth justsmth deleted the arch-support branch November 28, 2023 18:34
@justsmth justsmth mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants