Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for alpine linux #675

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 29, 2025

Issues:

Addresses: #658

Description of changes:

  • Build scripts now map the ???-alpine-linux-musl targets to the ???-unknown-linux-musl targets that we support.
  • Adds CI and docker image for testing builds on Alpine Linux.

Testing:

CI Job added,

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 29, 2025 18:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (c358484) to head (cc9f704).
Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   95.80%   92.84%   -2.96%     
==========================================
  Files          61       68       +7     
  Lines        8143     9747    +1604     
  Branches        0     9747    +9747     
==========================================
+ Hits         7801     9050    +1249     
- Misses        342      407      +65     
- Partials        0      290     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as draft January 30, 2025 14:05
@justsmth justsmth changed the title Add alpine linux docker image Improve support for alpine linux Jan 30, 2025
@justsmth justsmth mentioned this pull request Jan 30, 2025
@justsmth justsmth marked this pull request as ready for review January 30, 2025 15:01
@justsmth justsmth requested a review from skmcgrail January 30, 2025 19:10
@justsmth justsmth mentioned this pull request Jan 30, 2025
@justsmth justsmth requested a review from smittals2 January 30, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants