-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup EVP_PKEY serialization #669
Open
justsmth
wants to merge
14
commits into
aws:main
Choose a base branch
from
justsmth:cleanup-serialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+589
−817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 95.80% 92.87% -2.93%
==========================================
Files 61 69 +8
Lines 8143 9539 +1396
Branches 0 9539 +9539
==========================================
+ Hits 7801 8859 +1058
- Misses 342 399 +57
- Partials 0 281 +281 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
cleanup-serialization
branch
3 times, most recently
from
January 23, 2025 19:36
d22622c
to
eca53dc
Compare
justsmth
changed the title
[DRAFT} Cleanup EVP_PKEY serialization
[DRAFT] Cleanup EVP_PKEY serialization
Jan 23, 2025
justsmth
changed the title
[DRAFT] Cleanup EVP_PKEY serialization
Cleanup EVP_PKEY serialization
Jan 23, 2025
justsmth
force-pushed
the
cleanup-serialization
branch
from
January 24, 2025 16:36
eca53dc
to
7141306
Compare
skmcgrail
reviewed
Jan 27, 2025
skmcgrail
previously approved these changes
Jan 27, 2025
justsmth
force-pushed
the
cleanup-serialization
branch
from
January 28, 2025 22:06
10c07e9
to
e52f8ee
Compare
skmcgrail
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
EVP_marshal_private_key
,EVP_parse_private_key
,EVP_marshal_public_key
andEVP_parse_public_key
.EC_GROUP*
toconst
.ec:encoding
module.Call-outs:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.