Improve message when repo submods not initialized

aws · Jan 6, 2025 · 36e5159 · 36e5159
1 parent c5e6879
commit 36e5159
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/aws-lc-fips-sys/CMakeLists.txt b/aws-lc-fips-sys/CMakeLists.txt
@@ -22,6 +22,9 @@ if (BUILD_SHARED_LIBS AND FIPS)
 endif()
 
 add_subdirectory(aws-lc aws-lc EXCLUDE_FROM_ALL)
+if(NOT EXISTS aws-lc/CMakeLists.txt)
+message(WARNING "###### WARNING: MISSING GIT SUBMODULE ###### Did you initialize the repo's git submodules? CMakeLists.txt not found.")
+endif()
 
 if (BUILD_LIBSSL)
     add_definitions(-DAWS_LC_RUST_INCLUDE_SSL)

diff --git a/aws-lc-sys/CMakeLists.txt b/aws-lc-sys/CMakeLists.txt
@@ -18,6 +18,9 @@ if(BUILD_SHARED_LIBS)
 endif()
 
 add_subdirectory(aws-lc aws-lc EXCLUDE_FROM_ALL)
+if(NOT EXISTS aws-lc/CMakeLists.txt)
+message(WARNING "###### WARNING: MISSING GIT SUBMODULE ###### Did you initialize the repo's git submodules? CMakeLists.txt not found.")
+endif()
 
 if (BUILD_LIBSSL)
     add_definitions(-DAWS_LC_RUST_INCLUDE_SSL)

diff --git a/aws-lc-sys/builder/cc_builder.rs b/aws-lc-sys/builder/cc_builder.rs
@@ -267,14 +267,20 @@ impl CcBuilder {
         let mut ret_val = false;
         let output_dir = self.out_dir.join(format!("out-{basename}"));
         let mut cc_build = self.create_builder();
+        let source_file = self
+            .manifest_dir
+            .join("aws-lc")
+            .join("tests")
+            .join("compiler_features_tests")
+            .join(format!("{basename}.c"));
+        if !source_file.exists() {
+            emit_warning(&format!(
+                "###### WARNING: MISSING GIT SUBMODULE ###### Did you initialize the repo's git submodules? Unable to find source file: {:?}.",
+                &source_file
+            ));
+        }
         cc_build
-            .file(
-                self.manifest_dir
-                    .join("aws-lc")
-                    .join("tests")
-                    .join("compiler_features_tests")
-                    .join(format!("{basename}.c")),
-            )
+            .file(source_file)
             .warnings_into_errors(true)
             .out_dir(&output_dir);