Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-iot-device-sdk-java-v2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.0
Choose a base ref
...
head repository: aws/aws-iot-device-sdk-java-v2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref

Commits on Feb 17, 2022

  1. Modified Java code to allow passing Null as valid input for desired a…

    …nd reported properties (#216)
    
    * Modified Java code to allow passing Null as valid input for desired and reported properties
    * Renamed variableIsNullValid to variableIsNullable for better readability. Added setting IsNullable to parsing from payload
    * Removed legacy leftovers from a previous test attempt at passing Null
    TwistedTwigleg authored Feb 17, 2022
    Copy the full SHA
    6b711b1 View commit details

Commits on Mar 1, 2022

  1. refactor(greengrass): add with-ers and remove the return from setters…

    … which broke compatibility (#223)
    
    In release 1.6.0, we updated the Greengrass data model setters so that they return `this` so that calls could be chained. Unfortunately this broke binary compatibility which is necessary for Greengrass to maintain backward compatibility. This change should be released as version 1.7.0; it is compatible with versions <1.6.0. Users who are using >=1.6.0, will be able to upgrade to this version if they are not using the return value from the setters. They can also simply swap the calls to setX with a call to withX.
    MikeDombo authored Mar 1, 2022
    Copy the full SHA
    806162c View commit details

Commits on Mar 2, 2022

  1. Quick changes to Shadow sample (#219)

    * Quick changes to Shadow sample
    * Shadow sample style adjustment and closure of scanner
    TwistedTwigleg authored Mar 2, 2022
    Copy the full SHA
    51eb5ad View commit details
  2. Connection builder simplification (#218)

    Simplifies MQTT connection builder:
    * First pass at builder simplification for samples and general use
    * Second pass at builder simplification
    * Minor code cleanup missed during second pass at builder simplification
    * Updated code to work with builder simplification Java CRT changes
    * Adjusted to fit latest changes in CRT builder simplification branch
    * Adjusted samples based on feedback, removed vscode folder
    * Removed accidentally left behind comment
    * Updated crt submodule version
    TwistedTwigleg authored Mar 2, 2022
    Copy the full SHA
    aefbfcf View commit details
  3. Device Advisor Tests (#224)

    *Description of changes:*
    Added test samples for device advisor tests.
    
    Sample Name | Description and sample workflow | Test Cases
    -- | -- | --
    MQTT Connection | The sample will be used to test MQTT connection feature. It will 1. open a MQTT connection 2.wait for callback 3.Then close the connection. | MQTT- Connection
    MQTT Subscribe | The sample will be used to test MQTT connection feature. It will 1. open a MQTT connection 2.subscribe for a topic 3. wait for callback  4. close the connection. | MQTT- Subscribe
    MQTT Publish | The sample will be used to test MQTT connection feature. It will 1. open a MQTT connection 2.publish to a topic 3. wait for callback  4. close the connection. | MQTT- Publish
    Shadow Update | The sample will be used to test MQTT connection feature. It will 1. open a MQTT connection 2. update shadow field 3.close the connection. | Shadow-Shadow Publish, Shadow Update
    
    
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    xiazhvera authored Mar 2, 2022
    Copy the full SHA
    161da65 View commit details

Commits on Mar 3, 2022

  1. Refactor of command line argument parsing to single file (#221)

    * First pass at moving command line parsing to single file
    * Minor adjustment to PubSub sample to fix condition
    * Fixed typo in checking for websocket argument in pubsub sample
    TwistedTwigleg authored Mar 3, 2022
    Copy the full SHA
    c34b84e View commit details

Commits on Mar 15, 2022

  1. Copy the full SHA
    f956ba6 View commit details

Commits on Mar 24, 2022

  1. Support mutual TLS using a certificate from a Windows cert store (#235)

    Add the ability to use a client certificate located in a Windows certificate store. Previously, the client certificate and private key had to be passed by filepath or file contents. With this change, certificates and keys stored on TPM devices can be used.
    
    Add new `WindowsCertPubSub.java` sample to show this in action.
    graebm authored Mar 24, 2022
    Copy the full SHA
    85bb4fc View commit details
  2. update docs (#236)

    graebm authored Mar 24, 2022
    Copy the full SHA
    64b54c5 View commit details

Commits on Mar 25, 2022

  1. Sample logging and readme adjustment (#228)

    Adds note on logging to the samples README.
    
    * Added logging to samples, adjusted sample README to fit command line arguments
    * Removed verbosity command, added note on enabling logging in samples, and enabled system logging for all samples
    * Removed manually calling initLoggingFromSystemProperties since it is called automatically
    Co-authored-by: Bret Ambrose <bretambrose@gmail.com>
    TwistedTwigleg authored Mar 25, 2022
    Copy the full SHA
    60c79d0 View commit details
  2. README UPDATE (#234)

    Improve the Java READ_ME
    * Add notes for installing instructions and sample README
    * add prerequisites docs
    xiazhvera authored Mar 25, 2022
    Copy the full SHA
    d9c8d0d View commit details

Commits on Mar 30, 2022

  1. Issue templates (#243)

    * added issue templates
    jmklix authored Mar 30, 2022
    Copy the full SHA
    75dcec6 View commit details

Commits on Mar 31, 2022

  1. Fixed issue where IsNullable causing JSON issues (#241)

    Fixed issue where IsNullable could cause JSON to/from parsing issues.
    
    * Fixed issue where IsNullable causing JSON issues
    * Added ShadowState tests
    * Removed unused ShadowState test
    TwistedTwigleg authored Mar 31, 2022
    Copy the full SHA
    9cbc86b View commit details
  2. Feature android (#240)

    * Updating Android gradle files according to ver. 1.8.0
    
    Co-authored-by: Vitaly Khalmansky <vkhalmansky@klika-tech.com>
    Co-authored-by: Michael Graeb <graebm@amazon.com>
    Co-authored-by: Bret Ambrose <bretambrose@gmail.com>
    4 people authored Mar 31, 2022
    Copy the full SHA
    55cdd8d View commit details

Commits on Apr 1, 2022

  1. Split the PubSub sample down into smaller samples (#233)

    Splits the PubSub sample down into connect samples that only show how to make a connection.
    
    * Split pubsub samples into smaller connect samples
    * Added builder creation functions to command line utils and simplified pubsub sample
    * Further simplification of existing samples
    * Adjusted README to fit latest changes
    * Adjusted code based on code review:
    * Fixed websocket test passing region as the command instead of signing_region
    * Adjusted WindowsCertPubSub to WindowsCertConnect. Modified to fit other connect samples
    * Updated README to make command examples consistent
    TwistedTwigleg authored Apr 1, 2022
    Copy the full SHA
    79e839b View commit details

Commits on Apr 5, 2022

  1. Script to update aws-crt-java version number (#252)

    **ISSUE:**
    The aws-crt-java dependency version number is hard-coded in several places. We kept forgetting to update it everywhere it needed to be updated.
    
    **SOLUTION:**
    Create script to update the version number everwhere that it's currently hardcoded. Run it like:
    ```sh
    ./update-crt.py 0.16.0
    ```
    graebm authored Apr 5, 2022
    Copy the full SHA
    5c329f4 View commit details

Commits on Apr 6, 2022

  1. Copy the full SHA
    25cc589 View commit details
  2. feat: Standardize issue templates for discussions (#254)

    Co-authored-by: kellertk <kellertk@amazon.com>
    jmklix and kellertk authored Apr 6, 2022
    Copy the full SHA
    2a8a6c9 View commit details

Commits on Apr 7, 2022

  1. Copy the full SHA
    6d1b754 View commit details

Commits on Apr 11, 2022

  1. update crt to 0.16.3 (#256)

    For fixing the issue where `withReconnectTimeoutSecs` is not respected
    TingDaoK authored Apr 11, 2022
    Copy the full SHA
    a5dfadb View commit details

Commits on Apr 14, 2022

  1. Add ECC support for PKCS11. (#259)

    Update aws-crt dependency to get support. Actual implementation comes from PR awslabs/aws-c-io#479
    
    Co-authored-by: @JamieHunter
    graebm authored Apr 14, 2022
    Copy the full SHA
    745d78d View commit details
  2. Device Advisor CI automation (#232)

    Description of changes:
    Add the device advisor scripts to enable GitHub Actions to automatically run device advisor test on push
    
    GitHub Setting Changes:
    Added Repository secrets: AWS_DATEST_ACCESS_KEY_ID, AWS_DATEST_SECRET_ACCESS_KEY
    The secrets are set to aws-sdk-common-runtime user: IotSDKDeviceAdvisorCIAutomation
    
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    xiazhvera authored Apr 14, 2022
    Copy the full SHA
    4b150d2 View commit details

Commits on Apr 20, 2022

  1. Copy the full SHA
    1c75f3d View commit details
  2. Copy the full SHA
    b69a8f5 View commit details

Commits on Apr 21, 2022

  1. MQTT Username concatenate metrics query parameters (#264)

    Co-authored-by: Leonardo Nodari <me@leonardonodari.it>
    bretambrose and TheNodi authored Apr 21, 2022
    Copy the full SHA
    b33b08c View commit details
  2. Modify AlpnList if using custom authorizer (#265)

    * Added code to use mqtt in alpnList if trying to use custom authorizer
    * Add back port check to custom authorizer condition
    TwistedTwigleg authored Apr 21, 2022
    Copy the full SHA
    c04ce42 View commit details

Commits on Apr 25, 2022

  1. Autodocs (#266)

    Automated update the API documentation published to https://aws.github.io/aws-iot-device-sdk-java-v2/
    
    **Issue:**
    - Docs weren't updated unless someone remembered to do it manually.
    - Manually updating docs whenever you update code pollutes the diff, making it hard to review
    - Having HTML docs in `main` branch can cause issues.
       - Bloats size.
       - Generated docs might contain licenses we don't want to be redistributing.
    
    **Description of changes:**
    - Docs are kept in `docs` branch now
        - New `docs.yml` Github Workflow updates the `docs` branch whenever the `main` branch changes.
        - New `check-docs` job in `ci.yml` checks pull-requests for anything that would break docs.
        - delete the `docs/` folder in `main` and use `.gitignore` to prevent someone from accidentally resurrecting it.
    
    
    **TODO:**
    Turn on warnings as errors (in mavan-javadoc-plugin configuration add `<failsOnError>true</failsOnError>`). I tried turning it on but it was too much work to tackle today, since a lot of warnings were in the generated code.
    graebm authored Apr 25, 2022
    Copy the full SHA
    0b4c980 View commit details

Commits on Apr 29, 2022

  1. Copy the full SHA
    e260faf View commit details
  2. MQTT connection builder custom authorizer support (#268)

    Adds a custom authorizer sample, runs the sample in CI, and adds a custom authorizer builder.
    
    Commit log:
    * Added custom authorizer builder, adjusted custom authorizer detection code
    * Fixed checking incorrect port in validation check for custom authorizer connections
    * Updated after code review
    * Added test for custom authorizer connections
    * Fix samples README
    * Actually run the test... Oops
    * Use SDK focused custom authorizer
    * Fixed authorizer on server side
    * Adjusted to (hopefully) fix TLS connection issue on CI
    * Manually set the port in CI
    * Push to rerun CI
    * Adjust codebuild arguments to match order in local call
    * TMP - remove custom auth part to see if normal MQTT connection works
    * Enable custom auth and print username to diagnose the issue
    * Further information for finding issue
    * Remove log stuff. Add a one second delay to see if it is perhaps a timing issue on CI
    * Try running custom authorizer test along with normal connect tests
    * Try using CA file in Codebuild test
    * Use correct CA file
    * Remove CA file from test, disable testing custom authorizer for current PR
    * Adjusted after code review - cleaned up code and added better variable names. Enabled CI tests again
    * Fix Codebuild log printing
    * Remove passing CA file now that it is no longer saved in CI
    * Adjust custom authorizer conneciton so it does not send a key or certificate
    * Update python pip before installing boto3 in CI
    * CI - force pip reinstall
    * Revert pip update attempts
    * Test while waiting for Docker locally for additional testing
    * Revert test
    * Test: Use older version of Boto3
    * Revert test
    * Remove tests trying to get OpenSuse to work
    * Remove authorizer name and username, use secrets
    * Bump to rerun CI
    * Bump to rerun CI after server-side changes
    * Adjusted custom authorizer names in sample and code
    * Fix typo
    TwistedTwigleg authored Apr 29, 2022
    Copy the full SHA
    6dba2a1 View commit details

Commits on May 3, 2022

  1. Socket options leak (#271)

    (codebuild job completed successfully but GH doesn't seem to realize it)
    bretambrose authored May 3, 2022
    Copy the full SHA
    91c8312 View commit details

Commits on May 16, 2022

  1. Readme install instructions update (#273)

    * Updated README build from source section. Also updated prerequisites to use latest instructions from C++ repo
    * Typo fix
    TwistedTwigleg authored May 16, 2022
    Copy the full SHA
    d93fa0d View commit details

Commits on May 18, 2022

  1. Fixed Maven dependency naming issue (#275)

    Fixes the version number including the "v" prefix to the version in the README for Maven.
    timmattison authored May 18, 2022
    Copy the full SHA
    5232e51 View commit details
  2. Copy the full SHA
    6c78499 View commit details

Commits on May 20, 2022

  1. Copy the full SHA
    75a10c0 View commit details

Commits on May 26, 2022

  1. add ability to read RpcServer port bound when port auto selected by OS (

    #280)
    
    
    Co-authored-by: Vitaly Khalmansky <vkhalmansky@klika-tech.com>
    graebm and bgklika authored May 26, 2022
    Copy the full SHA
    c5337b1 View commit details

Commits on May 31, 2022

  1. Fix aws-crt-jni.dll files filling up Windows temp dir. (#283)

    Update to latest aws-crt. Contains [fix](awslabs/aws-crt-java#493) that, on startup, deletes any .dll files it finds from previous runs of the library.
    graebm authored May 31, 2022
    Copy the full SHA
    0bca07e View commit details

Commits on Jun 1, 2022

  1. Copy the full SHA
    cf207ac View commit details
  2. Update to latest version of CRT to get latest EventStream updates (#284)

    * Update to latest version of CRT to get latest EventStream updates
    * Testing if CI is working
    TwistedTwigleg authored Jun 1, 2022
    Copy the full SHA
    4d4c28f View commit details

Commits on Jun 2, 2022

  1. Give explicit permissions to Github actions (#286)

    because actions in this repo no longer have write permission by default.
    graebm authored Jun 2, 2022
    Copy the full SHA
    6c111aa View commit details

Commits on Jun 3, 2022

  1. Delete Test Resources for Device Advisor (#285)

    * update DA script: now it uploads the logs to s3 before delete the testing thing.
    
    * make sure delete test resource before exit
    
    * add backoff for device advisor request
    
    * update the print statement for logs path
    xiazhvera authored Jun 3, 2022
    Copy the full SHA
    d6c7f26 View commit details

Commits on Jun 7, 2022

  1. Copy the full SHA
    14fa606 View commit details

Commits on Jun 8, 2022

  1. feat: port internal event stream changes (#288)

    Co-authored-by: Bret Ambrose <bretambrose@gmail.com>
    MikeDombo and bretambrose authored Jun 8, 2022
    Copy the full SHA
    a39cab3 View commit details

Commits on Jun 23, 2022

  1. Copy the full SHA
    4c24436 View commit details

Commits on Jul 14, 2022

  1. Update CONTRIBUTING to reflect how CI works in our repos (#295)

    * Update CONTRIBUTING to reflect how CI works in our repos
    * Adjusted wording
    TwistedTwigleg authored Jul 14, 2022
    Copy the full SHA
    11c7ee1 View commit details

Commits on Jul 20, 2022

  1. Mention the default ClientID in the sample readme (#289)

    * Mention the default ClientID in the sample readme
    * Make client ID note smaller
    * Condense the wording so it all fits on a single line
    * Move note to the policy note
    TwistedTwigleg authored Jul 20, 2022
    Copy the full SHA
    4aec6d6 View commit details

Commits on Jul 25, 2022

  1. Update to use latest CRT (#297)

    * Update to use latest CRT
    * Update to latest CRT release
    * Update SDK to use latest CRT release
    * Update README to include correct version
    TwistedTwigleg authored Jul 25, 2022
    Copy the full SHA
    4b1bdc8 View commit details

Commits on Jul 26, 2022

  1. Copy the full SHA
    427f913 View commit details

Commits on Jul 28, 2022

  1. Update Greengrass V2 IPC model for PutComponentMetric operation (#296)

    * Update Greengrass V2 IPC model for PutComponentMetric operation
    
    * @kucnavya fix: increase timeout for subscriptionClosed from commit:
    4ea1e66
    
    Co-authored-by: Navya Kuchibhotla <kucnavya@amazon.com>
    Co-authored-by: Vera Xia <zhvxia@amazon.com>
    3 people authored Jul 28, 2022
    Copy the full SHA
    d59e0bb View commit details

Commits on Aug 1, 2022

  1. Custom TLS key operation support (#298)

    Adds custom key operation support to the Java V2 SDK.
    
    Commit log:
    * Enable custom TLS key operations
    * add missing arg to README
    * Refactor sample to use CommandLineUtils
    * Adjusted sample to work with latest changes to CRT for custom key operations
    * Added onCleanup callback to CustomKeyOpsPubSub sample
    * Minor sample change
    * Adjusted sample to not be stuck waiting for CRT resource, confirmed onCleanup function is being properly called
    * Remove testing code from sample and adjust README to mention Mutual TLS rather than MQTT
    * Fix the V2 sample and add the sample to codebuild CI
    * Update to latest CRT version
    * Fixed accidentally updating wrong part of pom.xml file
    * Modify linux-smoke-tests to run the custom key operations sample
    * Fixed typo in codebuild yaml...
    * Bump to trigger CI again
    
    Co-authored-by: Michael Graeb <graebm@amazon.com>
    TwistedTwigleg and graebm authored Aug 1, 2022
    Copy the full SHA
    d174606 View commit details

Commits on Aug 4, 2022

  1. Copy the full SHA
    e2cba66 View commit details
Showing 948 changed files with 38,588 additions and 128,720 deletions.
45 changes: 0 additions & 45 deletions .github/ISSUE_TEMPLATE/---bug-report.md

This file was deleted.

20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/---feature-request.md

This file was deleted.

16 changes: 0 additions & 16 deletions .github/ISSUE_TEMPLATE/---questions---help.md

This file was deleted.

73 changes: 73 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
---
name: "🐛 Bug Report"
description: Report a bug
title: "(short issue description)"
labels: [bug, needs-triage]
assignees: []
body:
- type: textarea
id: description
attributes:
label: Describe the bug
description: What is the problem? A clear and concise description of the bug.
validations:
required: true
- type: textarea
id: expected
attributes:
label: Expected Behavior
description: |
What did you expect to happen?
validations:
required: true
- type: textarea
id: current
attributes:
label: Current Behavior
description: |
What actually happened?
Please include full errors, uncaught exceptions, stack traces, and relevant logs.
If service responses are relevant, please include wire logs.
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Reproduction Steps
description: |
Provide a self-contained, concise snippet of code that can be used to reproduce the issue.
For more complex issues provide a repo with the smallest sample that reproduces the bug.
Avoid including business logic or unrelated code, it makes diagnosis more difficult.
The code sample should be an SSCCE. See http://sscce.org/ for details. In short, please provide a code sample that we can copy/paste, run and reproduce.
validations:
required: true
- type: textarea
id: solution
attributes:
label: Possible Solution
description: |
Suggest a fix/reason for the bug
validations:
required: false
- type: textarea
id: context
attributes:
label: Additional Information/Context
description: |
Anything else that might be relevant for troubleshooting this bug. Providing context helps us come up with a solution that is most useful in the real world.
validations:
required: false
- type: input
id: sdk-version
attributes:
label: SDK version used
validations:
required: true
- type: input
id: environment
attributes:
label: Environment details (OS name and version, etc.)
validations:
required: true
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
---
blank_issues_enabled: false
contact_links:
- name: 💬 General Question
url: https://github.com/aws/aws-iot-device-sdk-java-v2/discussions/categories/q-a
about: Please ask and answer questions as a discussion thread
23 changes: 23 additions & 0 deletions .github/ISSUE_TEMPLATE/documentation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: "📕 Documentation Issue"
description: Report an issue in the API Reference documentation or Developer Guide
title: "(short issue description)"
labels: [documentation, needs-triage]
assignees: []
body:
- type: textarea
id: description
attributes:
label: Describe the issue
description: A clear and concise description of the issue.
validations:
required: true

- type: textarea
id: links
attributes:
label: Links
description: |
Include links to affected documentation page(s).
validations:
required: true
59 changes: 59 additions & 0 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
---
name: 🚀 Feature Request
description: Suggest an idea for this project
title: "(short issue description)"
labels: [feature-request, needs-triage]
assignees: []
body:
- type: textarea
id: description
attributes:
label: Describe the feature
description: A clear and concise description of the feature you are proposing.
validations:
required: true
- type: textarea
id: use-case
attributes:
label: Use Case
description: |
Why do you need this feature? For example: "I'm always frustrated when..."
validations:
required: true
- type: textarea
id: solution
attributes:
label: Proposed Solution
description: |
Suggest how to implement the addition or change. Please include prototype/workaround/sketch/reference implementation.
validations:
required: false
- type: textarea
id: other
attributes:
label: Other Information
description: |
Any alternative solutions or features you considered, a more detailed explanation, stack traces, related issues, links for context, etc.
validations:
required: false
- type: checkboxes
id: ack
attributes:
label: Acknowledgements
options:
- label: I may be able to implement this feature request
required: false
- label: This feature might incur a breaking change
required: false
- type: input
id: sdk-version
attributes:
label: SDK version used
validations:
required: true
- type: input
id: environment
attributes:
label: Environment details (OS name and version, etc.)
validations:
required: true
Loading