Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secondary process crash #588

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pengjianzhang
Copy link

the secondary process cannot memset spp_dev to zero.

@kyyalama2
Copy link
Contributor

Can you please elaborate, what the issue seen was (if its failing a particular use-case, seeing errors etc) and how the update fixes the issue. Thanks

@pengjianzhang
Copy link
Author

pengjianzhang commented Nov 28, 2022

I start a primary process and then a secondary process; the primary process crashes. The location of the crash is in the function spp_tx_process_status(), and the statement "uint32_t status = tx_chan->tx_info.tx_status->status" accesses address zero.

The reason is that the secondary process cleared this memory by function eth_spp_init().
The secondary process can only attach these data structures and cannot modify them. I put 'memset' after checking the process's type.

@pengjianzhang
Copy link
Author

pengjianzhang commented Nov 29, 2022

image

rx_chan was cleared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants