Skip to content

Switch System.CommandLine to Spectre.CLI #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/net8-upgrade
Choose a base branch
from

Conversation

philasmar
Copy link
Contributor

@philasmar philasmar commented May 2, 2025

Issue #, if available:
DOTNET-8095

Description of changes:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label May 2, 2025
Base automatically changed from asmarp/net8-update to feature/net8-upgrade May 2, 2025 19:16
@philasmar philasmar closed this May 2, 2025
@philasmar philasmar reopened this May 2, 2025
@philasmar philasmar force-pushed the asmarp/switch-to-spectre-cli branch from ff3e778 to 284eaff Compare May 2, 2025 19:20
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 68.81356% with 276 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/net8-upgrade@33c3f79). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/AWS.Deploy.CLI/Commands/DeployCommand.cs 60.76% 130 Missing and 34 partials ⚠️
...AWS.Deploy.CLI/Commands/DeleteDeploymentCommand.cs 65.76% 27 Missing and 11 partials ⚠️
...y.CLI/Commands/GenerateDeploymentProjectCommand.cs 84.03% 10 Missing and 9 partials ⚠️
src/AWS.Deploy.CLI/Utilities/CommandLineHelpers.cs 26.31% 12 Missing and 2 partials ⚠️
src/AWS.Deploy.CLI/Commands/ServerModeCommand.cs 74.50% 12 Missing and 1 partial ⚠️
src/AWS.Deploy.DocGenerator/Program.cs 0.00% 8 Missing ⚠️
src/AWS.Deploy.CLI/App.cs 88.88% 4 Missing and 3 partials ⚠️
src/AWS.Deploy.CLI/Program.cs 0.00% 7 Missing ⚠️
...AWS.Deploy.CLI/Commands/CancellableAsyncCommand.cs 70.00% 3 Missing ⚠️
src/AWS.Deploy.CLI/Utilities/TypeResolver.cs 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #920   +/-   ##
=======================================================
  Coverage                        ?   62.34%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10736           
  Branches                        ?     1559           
=======================================================
  Hits                            ?     6693           
  Misses                          ?     3484           
  Partials                        ?      559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar force-pushed the asmarp/switch-to-spectre-cli branch from 531f785 to 96e5ca8 Compare May 3, 2025 20:57
@philasmar philasmar requested review from normj and GarrettBeatty May 3, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant