Upgrade to AWS SDK Go v2 #506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash97
reviewed
Jan 10, 2025
|
|
||
| import "errors" | ||
|
|
||
| func Int64ToInt32(value int64) (int32, error) { |
There was a problem hiding this comment.
why do we need this functions? Also i see int64 was changed to int32. Please provide reason this change.
There was a problem hiding this comment.
In v2, field Ipv4PrefixCount is changed to int32 for some structs, eg:
- https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ec2#CreateNetworkInterfaceInput
- https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ec2#AssignPrivateIpAddressesInput
So decided to also change the interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Close #471
Close #472
Description of changes:
Component that still using v1
"pkg/aws/ec2/api/wrapper.go".ec2Wrapper.getRegionalStsEndpoint is the only function still use V1. Leave it as TODO. The only way I can think of is to clone v1
endpointscode into this repo. Please help give opinion on this.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.