Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating api-machinery, client-go #493

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Updating api-machinery, client-go #493

merged 4 commits into from
Dec 12, 2024

Conversation

yash97
Copy link
Contributor

@yash97 yash97 commented Nov 14, 2024

Issue #, if available:

Description of changes:
ChangeLog for controller-runtime:-
⚠️ Deprecation Warnings
Please note that admission.Defaulter/Validator have been deprecated in favor of admission.CustomDefaulter/CustomValidator since v0.17 and will be removed with v0.20.

⚠️ Breaking Changes
Bump to k8s.io/* v1.31 (kubernetes-sigs/controller-runtime#2798 kubernetes-sigs/controller-runtime#2858 kubernetes-sigs/controller-runtime#2867 kubernetes-sigs/controller-runtime#2872 kubernetes-sigs/controller-runtime#2883 kubernetes-sigs/controller-runtime#2900 kubernetes-sigs/controller-runtime#2906 kubernetes-sigs/controller-runtime#2924)
Add generic TypedReconciler (kubernetes-sigs/controller-runtime#2799)
client: Remove options.WarningHandler (kubernetes-sigs/controller-runtime#2887 kubernetes-sigs/controller-runtime#2903)
controller: Validate controller names are unique & add SkipNameValidation option (kubernetes-sigs/controller-runtime#2902 kubernetes-sigs/controller-runtime#2918)

We do not seem to be affected by any breaking change and deprecation as I am getting green build and integration test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dependabot bot and others added 3 commits September 19, 2024 22:26
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.30.2 to 0.31.1.
- [Commits](kubernetes/apimachinery@v0.30.2...v0.31.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@yash97 yash97 requested a review from a team as a code owner November 14, 2024 22:31
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yash97 yash97 merged commit 603e419 into aws:master Dec 12, 2024
4 checks passed
yash97 added a commit to yash97/amazon-vpc-resource-controller-k8s that referenced this pull request Dec 13, 2024
* Bump k8s.io/apimachinery from 0.30.2 to 0.31.1

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.30.2 to 0.31.1.
- [Commits](kubernetes/apimachinery@v0.30.2...v0.31.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* upgrading client-go, controller-runtime versions too

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yash97 added a commit that referenced this pull request Dec 17, 2024
* Add flags to configure controller parameters (#492)

* Add flags to configure controller parameters

* update flag names

* Bump github.com/onsi/ginkgo/v2 from 2.19.0 to 2.22.0 (#497)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.19.0 to 2.22.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.19.0...v2.22.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* skip leaked ENIs cleanup on unmanaged nodes

* Updating api-machinery, client-go (#493)

* Bump k8s.io/apimachinery from 0.30.2 to 0.31.1

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.30.2 to 0.31.1.
- [Commits](kubernetes/apimachinery@v0.30.2...v0.31.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* upgrading client-go, controller-runtime versions too

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* updating limits go bt not deleting g3 instances (#501)

* Bump github.com/aws/amazon-vpc-cni-k8s from 1.18.1 to 1.18.3 (#446)

* Bump github.com/aws/amazon-vpc-cni-k8s from 1.18.1 to 1.18.3

Bumps [github.com/aws/amazon-vpc-cni-k8s](https://github.com/aws/amazon-vpc-cni-k8s) from 1.18.1 to 1.18.3.
- [Release notes](https://github.com/aws/amazon-vpc-cni-k8s/releases)
- [Changelog](https://github.com/aws/amazon-vpc-cni-k8s/blob/v1.18.3/CHANGELOG.md)
- [Commits](aws/amazon-vpc-cni-k8s@v1.18.1...v1.18.3)

---
updated-dependencies:
- dependency-name: github.com/aws/amazon-vpc-cni-k8s
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* update decoder type to fix presubmit failures

* update auto-generated CRD file

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sushrk <[email protected]>

* use protobuf content type instead of json for k8s client (#484)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sushmitha Ravikumar <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sushrk <[email protected]>
Co-authored-by: Bhavitha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants