-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onPipChange #155
feat: onPipChange #155
Conversation
Hey @Bowlerr we are working through merging these pip related PRs, will need to resolve a conflict here. |
@@ -371,6 +382,20 @@ class AmazonIvsView(private val context: ThemedReactContext) : FrameLayout(conte | |||
private fun intervalHandler() { | |||
val reactContext = context as ReactContext | |||
|
|||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we lean on https://developer.android.com/develop/ui/views/picture-in-picture#handling_ui
override fun onPictureInPictureModeChanged(
isInPictureInPictureMode: Boolean, newConfig: Configuration) {
instead of relying on polling the state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I attempted this but couldn't get it triggering so I went with polling as a last ditch effort as I needed something working at the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However once the other PiP PR had been merged, I am happy to test it again :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dawhitla,
Last time I attempted to use this, it never triggered / claimed to override nothing.
override fun onPictureInPictureModeChanged( isInPictureInPictureMode: Boolean, newConfig: Configuration) { ...
Is there something I am missing?
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can pull your fork and take a look at why onPictureInPictureModeChanged
does not trigger 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have cleaned this up a little replacing:
if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.N && reactContext.packageManager .hasSystemFeature( PackageManager.FEATURE_PICTURE_IN_PICTURE))
with
if(pipEnabled)
in the intervalHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I figured out why onPictureInPictureModeChanged
isn't happening for the view
It's a function of a callback on the activity itself. src/main/java/com/facebook/react/ReactActivity.java
So hooking into onPictureInPictureModeChanged
would require a manual setup 😮💨
Here is what another RN lib did
https://github.com/adkaushik/react-native-pip-android#setup
We may need to rely on the interval check for the time being for easier DX (no manual setup step)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thank you ! @dawhitla
I believe that's where I got to before switching to the interval check. Although it isn't ideal, the interval check has been reliable in our production use case :) Check out Moar if you want to see it in action.
I am happy to look into getting this done at some point but other priorities have taken my focus for the time being. Feel free to merge as is
Unsure why the ios test failed 🤔 |
Issue #, if available:
At the moment, we can't have the audio of the video mute when the video is in the background and picture in picture is not active as we are not aware of the state changes to Picture in Picture.
Description of changes:
Adds
onPipChange
prop to IVSPlayer.Native code which tracks if picture in picture is opened or closed.
Example use case to solve Issue stated:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.