Implement agent introspection server in ecs-agent #4482
Merged
+1,970
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per suggestion from @sparrc, I am splitting Move introspection server to ecs-agent into two pull requests:
|
This was referenced Jan 28, 2025
mye956
reviewed
Jan 28, 2025
mye956
reviewed
Jan 28, 2025
mye956
reviewed
Jan 28, 2025
mye956
reviewed
Jan 28, 2025
mye956
reviewed
Jan 28, 2025
mye956
reviewed
Jan 28, 2025
amogh09
reviewed
Jan 29, 2025
mye956
reviewed
Jan 29, 2025
mye956
reviewed
Jan 29, 2025
mye956
reviewed
Jan 29, 2025
amogh09
reviewed
Jan 30, 2025
amogh09
approved these changes
Jan 30, 2025
mye956
approved these changes
Jan 31, 2025
To make the Agent Introspection Server available to the Fargate agent, the introspection server is now implemented in the shared ecs-agent library, where it can be consumed by both agents.
willmyrs
force-pushed
the
share_introspection
branch
from
6ef783f to
75de604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the effort to bring the Agent Introspection Server to the Fargate Agent, this change implements the agent
introspectionserver in the sharedecs-agentlibrary.Implementation details
The http server logic for the introspection server is implemented in the shared
ecs-agentlibrary. This refactored server is responsible for handling http requests and generating responses. The server defines anAgentStateinterface which will be implemented in the ECS and Fargate agents. TheAgentStateimplementations will supply the server with the data it needs to construct responses.Testing
Unit and integration tests
New unit and integration tests were added to the
introspectionpackage inecs-agent. Where applicable, existing tests were copied and modified to help ensure the new server implementation will have the same outward-facing behavior.Description for the changelog
Feature - Implement agent introspection server in shared library
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.