Fix potential out of bounds panic #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
reviewed
Aug 1, 2024
dricross
force-pushed
the
fix-backoff-sleep-panic
branch
from
4d3797a to
93f0920
Compare
|
This PR was marked stale due to lack of activity. |
musa-asad
approved these changes
Aug 9, 2024
lisguo
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The
TestTranslator/WithKubernetes/WithoutClusterNameunit test is failing locally due to a panic inbackoffSleepon this line: https://github.com/aws/amazon-cloudwatch-agent/blob/main/translator/translate/logs/util/get_eks_cluster_name.go#L117. The call to ec2.DescribeTags to attempt to find the Kubernetes cluster name is failing (due to an environment issue), and it retries 6 times. On the sixth attempt, it attempts to access sleeps[5] which is invalid causing a panic.This panic behavior would happen outside unit testing if the ec2.DescribeTags call fails more than 5 times.
Description of changes
Maintain behavior of retrying 6 times, but only pull from pre-defined sleep durations on attempts 1-5. On 6th attempt, use default duration.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Create new unit test for function that was panicing. Before changes, the unit test panics regardless of environment configuration. After changes, the unit test does not panic.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint