Add dynamic timewait in integ tests #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added instructions to run 2 integ for each windows os version
mitali-salvi
approved these changes
Feb 9, 2024
movence
reviewed
Feb 9, 2024
| curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| ./kubectl rollout status daemonset fluent-bit-windows -n amazon-cloudwatch --timeout 600s | ||
| ./kubectl rollout status daemonset cloudwatch-agent-windows -n amazon-cloudwatch --timeout 600s |
There was a problem hiding this comment.
Is 2m always enough? any chance that we need to loop this?
movence
approved these changes
Feb 9, 2024
KlwntSingh
added a commit
to KlwntSingh/amazon-cloudwatch-agent-operator
that referenced
this pull request
Mar 2, 2024
* Add dynamic timewait in integ tests * Added missed wait time * Added windows integ tests as part of integ 1. Added instructions to run 2 integ for each windows os version * Update pod count in tests
KlwntSingh
added a commit
to KlwntSingh/amazon-cloudwatch-agent-operator
that referenced
this pull request
Mar 18, 2024
* Add dynamic timewait in integ tests * Added missed wait time * Added windows integ tests as part of integ 1. Added instructions to run 2 integ for each windows os version * Update pod count in tests
KlwntSingh
added a commit
that referenced
this pull request
Mar 18, 2024
* Add dynamic timewait in integ tests * Added missed wait time * Added windows integ tests as part of integ 1. Added instructions to run 2 integ for each windows os version * Update pod count in tests
KlwntSingh
added a commit
to KlwntSingh/amazon-cloudwatch-agent-operator
that referenced
this pull request
Mar 18, 2024
* Add dynamic timewait in integ tests * Added missed wait time * Added windows integ tests as part of integ 1. Added instructions to run 2 integ for each windows os version * Update pod count in tests
lisguo
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Operator image and integ tests (#59) * Add helm template for CW agent on Windows 1. Made change in operator to dynamically mutate operator to add cwagentconfig MountVolume 2. Added github workflow to build and upload cwagent operator to internal ECR repo 3. Added integration tests against helm addon 4. Added terraform module to run test against EKS Windows cluster 5. Update go tests with linuxonly and Windows tags * Fix: Change resource limit values to same as linux # Conflicts: # helm/templates/_helpers.tpl # pkg/collector/container.go # Conflicts: # helm/templates/_helpers.tpl # helm/values.yaml # integration-tests/eks/validateResources_test.go * Run CW agent as host process container (#67) * Fix issues in helm charts during e2e testing (#75) * Update helm templates for CW agent and fluent bit on Windows * Removing configuration about kubernetes from fluentbit * Disable AppSignal on EKS Windows (#76) # Problem AppSignal is having issues around initializing k8s client on EKS Windows when running it as Host process container. Similar issues existed for CI Windows but workaround was implemented for CI, similar workaround is required for AppSignal or We can upgrade container to 1.7 which solves this issue. # Conflicts: # helm/values.yaml * Add dynamic timewait in integ tests (#82) * Add dynamic timewait in integ tests * Added missed wait time * Added windows integ tests as part of integ 1. Added instructions to run 2 integ for each windows os version * Update pod count in tests * Change fluentbit configuration to use in-memory (#86) Increased fluentbit request/limits according to public eks fluentbit blog * Add todo to fix link to container image (#97) 1. Added todo's to fix link to CI 2. Change tag to fluentbit on Windows # Conflicts: # helm/values.yaml * Remove temporary changes for dev testing # Conflicts: # helm/templates/_helpers.tpl * 1. Remove customer configuration for CW agent on Windows 2. Change cpu, memory request limits when fluentbit log is disabled. * Add region in deployment on Windows * Add region in helm deployment * Fix: windows service and daemonset is created irrespective of Windows node # Conflicts: # integration-tests/eks/resourceCount_linuxonly_test.go * Add comments and update version.txt 1. Added comments in resourcecount_test files 2. Update CW agent version in version.txt file * Address comments 1. Update operation version to 1.2 2. renamed CW agent windows daemonset file name * Address comments 1. Update helm chart versions 2. Add unit tests for Windows specific changes in operator * Restructure deployments specific to Linux and Windows * Fix relative to deployments * Add nodeSelector for dcgm node selector * Fix integ tests for Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.